After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 531487 - background plugin brokenness
background plugin brokenness
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-05-05 05:15 UTC by Matthias Clasen
Modified: 2008-07-04 20:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix background plugin (1.08 KB, patch)
2008-05-05 05:15 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2008-05-05 05:15:02 UTC
If show_desktop is set, then the background capplet skips the initial apply_prefs call on the assumption that nautilus might start later to handle the background. 
But if that does not happen (some people still run nautilus-less sessions...), we never call apply_prefs again.

There are two bugs here:

1) we need to call apply_prefs at login eventually, after nautilus had enough time to start up

2) we need to call apply_prefs when background settings in gconf change. The code tries to do that, but fails. Admittely, gconf_client_notify_add is a bit of a trap, since it won't work without a corresponding gconf_client_add_dir.

The attached patch fixes both of these issues.
Comment 1 Matthias Clasen 2008-05-05 05:15:50 UTC
Created attachment 110388 [details] [review]
fix background plugin
Comment 2 Jens Granseuer 2008-05-05 18:16:15 UTC
Thanks. The second issuewas already fixed in trunk. I've also increased the timeout slightly, since 5 seconds probably isn't enough to get nautilus up and running.
Comment 3 Ian 2008-07-04 20:47:48 UTC
Until this fix finds its way into mainstream distribution, is there a way that one could manually force gnome-settings-daemon to apply_prefs ?