After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530720 - Don't allow recursive move/copy into itself
Don't allow recursive move/copy into itself
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 518413 534270 536409 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-30 11:54 UTC by Tomas Bzatek
Modified: 2008-06-29 22:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
nautilus-copymove_inside_itself.patch (3.01 KB, patch)
2008-04-30 11:57 UTC, Tomas Bzatek
committed Details | Review

Description Tomas Bzatek 2008-04-30 11:54:51 UTC
This is a feature regression since Nautilus GIO port (2.21.x). 
Nautilus doesn't check whether the target folder lies within source structure, possibly leading to recursive copy until a filesystem limit is reached.
Comment 1 Tomas Bzatek 2008-04-30 11:57:31 UTC
Created attachment 110156 [details] [review]
nautilus-copymove_inside_itself.patch

Proposed patch, waiting for acks before commit.
Comment 2 Christian Neumair 2008-05-03 12:43:32 UTC
Good catch, confirming.

Please commit the patch to trunk. Unfortunately, due to string and UI freze we can not commit it to the stable branch. LTS distributors may want to back-port this one, though.
Comment 3 Tomas Bzatek 2008-05-05 09:44:33 UTC
Thanks for reviewing this.

Commited to trunk as revision 14131.
Comment 4 Cosimo Cecchi 2008-05-05 13:01:34 UTC
*** Bug 518413 has been marked as a duplicate of this bug. ***
Comment 5 Cosimo Cecchi 2008-05-21 23:21:59 UTC
*** Bug 534270 has been marked as a duplicate of this bug. ***
Comment 6 A. Walton 2008-06-03 11:50:49 UTC
*** Bug 536409 has been marked as a duplicate of this bug. ***
Comment 7 Gilles Dartiguelongue 2008-06-29 22:13:32 UTC
fixing status.