After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530617 - Avahi browser code has hardcoded values
Avahi browser code has hardcoded values
Status: RESOLVED WONTFIX
Product: ekiga
Classification: Applications
Component: Presence stack
GIT master
Other All
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2008-04-29 19:36 UTC by Damien Sandras
Modified: 2020-06-06 16:30 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Description Damien Sandras 2008-04-29 19:36:52 UTC 
Please describe the problem:
The Avahi browser code has hardcoded sip magic values. It should not be hardcoded, and it should support more protocols.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Matthias Schneider 2008-09-12 23:12:06 UTC 
Still valid?
Comment 2 Snark 2008-09-14 18:49:14 UTC 
It's obsolete :-)
Comment 3 Damien Sandras 2008-09-14 19:04:56 UTC 
Well, yes and no. We still hardcode SIP and UDP there. We should get the supported protocols from another part of the engine, not hardcode them.
Comment 4 Snark 2008-09-14 21:14:18 UTC 
Ah, yes, it's the avahi publishing code which does :
    typ = g_strdup_printf ("_%s._%s",
			   iter->voip_protocol.c_str (),
			   iter->protocol.c_str ());

and hence is correct.

The browser code still does :
    browser = avahi_service_browser_new (client,
					 AVAHI_IF_UNSPEC,
					 AVAHI_PROTO_UNSPEC,
					 "_sip._udp", NULL,
					 (AvahiLookupFlags)0,
					 avahi_browser_callback,
					 this);

Definitely not for 3.0, 3.01 is too short, let's shoot for 3.20.
Comment 5 Snark 2009-06-12 12:39:48 UTC 
Removing the target : we obviously missed it.

It may not be that hard to do, but I'm not feeling that motivated to do the modification for now :
- one should make the browser code allow several browsers ;
- once that is done, it will just be a game of looping on the supported protocols, just like in the publishing code.
Comment 6 André Klapper 2020-06-06 16:30:26 UTC 
Ekiga is not under active development anymore:
https://gitlab.gnome.org/Infrastructure/Infrastructure/-/issues/273

Ekiga saw its last release 7 years ago. The last code commits were 4 years ago.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (and transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active Ekiga development again in the future.