After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530589 - Yelp:ERROR:(yelp-document.c:275):yelp_document_cancel_page: assertion failed: (document != NULL && YELP_IS_DOCUMENT (document))
Yelp:ERROR:(yelp-document.c:275):yelp_document_cancel_page: assertion failed:...
Status: RESOLVED OBSOLETE
Product: yelp
Classification: Applications
Component: General
2.22.x
Other Linux
: Normal major
: ---
Assigned To: Yelp maintainers
Yelp maintainers
: 530634 547893 562733 564600 568169 573839 612543 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-29 16:27 UTC by Sebastien Bacher
Modified: 2011-04-30 15:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
fix g_free crasher (407 bytes, patch)
2009-10-20 13:46 UTC, Michael Terry
none Details | Review
Fix canceling page (875 bytes, patch)
2009-10-20 13:47 UTC, Michael Terry
none Details | Review

Description Sebastien Bacher 2008-04-29 16:27:24 UTC
The bug has been described on https://bugs.launchpad.net/ubuntu/+source/yelp/+bug/220142

"On 8.04 Release Candidate Yelp window closes silently and .xsession-error contains

Yelp:ERROR:(yelp-document.c:275):yelp_document_cancel_page: assertion failed: (document != NULL && YELP_IS_DOCUMENT (document))

when these steps are followed:

Open yelp window
Go to Advanced Topics
Go to Writing Your Own Programs
Go to Learning how to program

On my machine nothing happens except a spinning-disk pointer. Impatiently select "Learning how to program" again and Poof!"

the corresponding stacktrace

"#0  0xb7f74410 in __kernel_vsyscall ()
  • #1 raise
    from /lib/tls/i686/cmov/libc.so.6
  • #2 abort
    from /lib/tls/i686/cmov/libc.so.6
  • #3 IA__g_assertion_message
  • #4 IA__g_assertion_message_expr
  • #5 yelp_document_cancel_page
    at yelp-document.c line 275
  • #6 window_setup_window
    at yelp-window.c line 933
  • #7 yelp_window_load
    at yelp-window.c line 1108
  • #8 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #9 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #10 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2199
  • #11 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #12 html_open_uri
    at yelp-html.cpp line 101
  • #13 gtkmozembed_BOOLEAN__STRING
    at gtkmozembedmarshal.c line 82
  • #14 g_type_class_meta_marshal
  • #15 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #16 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2478
  • #17 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2209
  • #18 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #19 EmbedContentListener::OnStartURIOpen
    at EmbedContentListener.cpp line 82
  • #20 nsDSURIContentListener::OnStartURIOpen
    at nsDSURIContentListener.cpp line 105
  • #21 nsURILoader::OpenChannel
    at nsURILoader.cpp line 880
  • #22 nsURILoader::OpenURI
    at nsURILoader.cpp line 830
  • #23 nsDocShell::DoChannelLoad
    at nsDocShell.cpp line 7531
  • #24 nsDocShell::DoURILoad
    at nsDocShell.cpp line 7377
  • #25 nsDocShell::InternalLoad
    at nsDocShell.cpp line 7102
  • #26 nsWebShell::OnLinkClickSync
    at nsWebShell.cpp line 891
  • #27 OnLinkClickEvent::Run
    at nsWebShell.cpp line 726
  • #28 nsThread::ProcessNextEvent
    at nsThread.cpp line 510
  • #29 NS_ProcessPendingEvents_P
    at nsThreadUtils.cpp line 180
  • #30 nsBaseAppShell::NativeEventCallback
    at nsBaseAppShell.cpp line 121
  • #31 nsAppShell::EventProcessorCallback
    at nsAppShell.cpp line 69
  • #32 g_io_unix_dispatch
  • #33 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2009
  • #34 g_main_context_iterate
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2642
  • #35 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.16.3/glib/gmain.c line 2850
  • #36 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #37 main
    at yelp-main.c line 121

Comment 1 Claude Paroz 2008-05-02 16:11:03 UTC
*** Bug 530634 has been marked as a duplicate of this bug. ***
Comment 2 Don Scorgie 2008-05-22 07:08:59 UTC
I can reproduce.  Confirming and I'll investigate.  Thanks.
Comment 3 Tomasz Dominikowski 2008-08-27 15:44:14 UTC
I can confirm this bug with latest svn trunk of yelp (open help, type "startup" in search field, try opening "Disk Usage Analyzer Manual"). 

It's strange, because in that particular example, if you search for "baobab" and open "Disk Usage Analyzer Manual" from that list, it opens fine.

Similar thing happens with Conduit's help. You can't open any topics if you open help from the program, but if you search for conduit separately by just running yelp and typing "conduit", the whole manual works fine. 
Comment 4 palfrey 2008-12-01 00:55:53 UTC
*** Bug 562733 has been marked as a duplicate of this bug. ***
Comment 5 palfrey 2008-12-15 17:15:21 UTC
*** Bug 564600 has been marked as a duplicate of this bug. ***
Comment 6 Gianluca Borello 2009-01-18 14:09:14 UTC
*** Bug 568169 has been marked as a duplicate of this bug. ***
Comment 7 palfrey 2009-03-03 11:21:01 UTC
*** Bug 573839 has been marked as a duplicate of this bug. ***
Comment 8 Jouni Mettala 2009-03-14 13:53:33 UTC
I can't reproduce this anymore with yelp 2.25.1-0ubuntu2
Comment 9 Jouni Mettala 2009-03-16 16:58:31 UTC
I can still reproduce by clicking Connecting to the internet.
Comment 10 Michael Terry 2009-10-20 13:46:22 UTC
Created attachment 145859 [details] [review]
fix g_free crasher

Here's a patch from the Ubuntu bug that fixes some g_free crashers.  The bug in the Ubuntu bug is against a slightly older version.  Some of the g_free issues have been fixed in git.  But there's one missing case, here in this patch.  Patch by Bill Filler.
Comment 11 Michael Terry 2009-10-20 13:47:08 UTC
Created attachment 145860 [details] [review]
Fix canceling page

Here's another crasher patch from the Ubuntu bug, also by Bill Filler.
Comment 12 Michael Terry 2009-10-20 13:47:50 UTC
Instead of "the bug in the Ubuntu bug is against a slightly older version", I meant "the patch in..."
Comment 13 C de-Avillez 2010-03-11 21:08:37 UTC
Still present on 2.29.5:

**
Yelp:ERROR:yelp-document.c:275:yelp_document_cancel_page: assertion failed: (document != NULL && YELP_IS_DOCUMENT (document))

Program received signal SIGABRT, Aborted.
0x00007ffff3e25a85 in *__GI_raise (sig=<value optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
64	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
	in ../nptl/sysdeps/unix/sysv/linux/raise.c
(gdb) bt
  • #0 *__GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #1 *__GI_abort
    at abort.c line 92
  • #2 IA__g_assertion_message
  • #3 IA__g_assertion_message_expr
    at /build/buildd/glib2.0-2.23.5/glib/gtestutils.c line 1329
  • #4 yelp_document_cancel_page
    at yelp-document.c line 275
  • #5 window_setup_window
    at yelp-window.c line 966
  • #6 yelp_window_load
    at yelp-window.c line 1174
  • #7 html_uri_selected_cb
  • #8 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.23.5/gobject/gclosure.c line 767
  • #9 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 3248
  • #10 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 2981
  • #11 IA__g_signal_emit
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 3038
  • #12 html_open_uri
    at yelp-html.cpp line 110
  • #13 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #14 IA__g_closure_invoke
  • #15 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 3286
  • #16 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 2991
  • #17 IA__g_signal_emit
    at /build/buildd/glib2.0-2.23.5/gobject/gsignal.c line 3038
  • #18 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #19 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #20 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #21 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #22 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #23 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #24 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #25 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #26 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #27 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #28 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #29 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #30 ??
    from /usr/lib/xulrunner-1.9.1.9pre/libxul.so
  • #31 g_main_dispatch
    at /build/buildd/glib2.0-2.23.5/glib/gmain.c line 1960
  • #32 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.23.5/glib/gmain.c line 2513
  • #33 g_main_context_iterate
    at /build/buildd/glib2.0-2.23.5/glib/gmain.c line 2591
  • #34 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.23.5/glib/gmain.c line 2799
  • #35 IA__gtk_main
    at /build/buildd/gtk+2.0-2.19.6/gtk/gtkmain.c line 1219
  • #36 main_start
    at yelp-main.c line 117
  • #37 main
    at yelp-main.c line 430

Comment 14 C de-Avillez 2010-03-11 21:24:57 UTC
*** Bug 612543 has been marked as a duplicate of this bug. ***
Comment 15 Rupert Swarbrick 2011-03-30 09:20:04 UTC
I don't think this bug can possibly still be present in the Yelp in the git master repository, since the load cancelling code has been completely rewritten. Moreover, it seems this must have been caused by priv->current_request being other than -1 when priv->current_document was NULL in yelp-window.c. Neither of these variables exist any more.

Unfortunately, I can't actually reproduce the bug in my debian Lenny kvm instance, but this might be because I haven't managed to install the right document packages to make it possible :-(

However, I'm pretty certain this bug must be fixed in git and, if there's a bug with the same symptoms, it will be in completely different code from the one above, so I would suggest closing this report.
Comment 16 Shaun McCance 2011-04-30 15:51:44 UTC
Agree with Rupert's assessment. Resolving.
Comment 17 Shaun McCance 2011-04-30 15:57:33 UTC
*** Bug 547893 has been marked as a duplicate of this bug. ***