After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530549 - Cannot add new emblems in Nautilus
Cannot add new emblems in Nautilus
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-29 12:37 UTC by Pedro Villavicencio
Modified: 2008-04-30 09:30 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
trivial patch (953 bytes, patch)
2008-04-30 09:30 UTC, Cosimo Cecchi 		committed Details | Review

Description Pedro Villavicencio 2008-04-29 12:37:24 UTC 
This bug has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/224162

"Open Nautilus.
Open up backgrounds and emblems dialog.
Choose emblems.
Add a new emblem.
Type a name for the Emblem.
Navigate to the directory containing your emblem picture file.

Select the new emblem and a message will pop-up saying that you have an invalid picture file.
Any of the existing files which are emblems already will also fail. I tried both PNG or SVG."

Thanks,
Comment 1 Cosimo Cecchi 2008-04-30 09:30:27 UTC 
Created attachment 110149 [details] [review]
trivial patch

This happened because we were unreffing the GFileInfo before checking the mime type, invalidating the const mime_type string.
I committed this trivial patch both to trunk and gnome-2-22.
Comment 2 Cosimo Cecchi 2008-04-30 09:30:56 UTC 
Closing as FIXED.

2008-04-30  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-property-browser.c: (ensure_file_is_image):
	Do not unref the file info before checking the mime type,
	otherwise the mime_type string will be invalidated. (#530549).