After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530529 - [patch] "make install -j2" fails because of missing dependencies
[patch] "make install -j2" fails because of missing dependencies
Status: RESOLVED FIXED
Product: gnome-audio
Classification: Deprecated
Component: General
2.22.x
Other All
: Normal normal
: ---
Assigned To: GNOME Audio Maintainers
GNOME Audio Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-29 10:01 UTC by Vaclav Slavik
Modified: 2008-04-29 16:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
patch to fix make install (513 bytes, patch)
2008-04-29 10:02 UTC, Vaclav Slavik
committed Details | Review

Description Vaclav Slavik 2008-04-29 10:01:48 UTC
Please describe the problem:
The install-default-links target in sounds/Makefile is missing dependency on install-files. Because of it, make may execute install-default-links first or in parallel (as it does with -jN for N>1). "ln -s" command then fails because the target directory doesn't exist yet:

make -C sounds install
make[1]: Entering directory `/var/tmp/portage/gnome-extra/gnome-audio-2.22.1/work/gnome-audio-2.22.1/sounds'
for I in *.wav */*.wav ; do \
		mkdir -p /var/tmp/portage/gnome-extra/gnome-audio-2.22.1/image///usr/share/sounds/`dirname $I`; \
		install -c -m 444  $I /var/tmp/portage/gnome-extra/gnome-audio-2.22.1/image///usr/share/sounds/$I; \
	done
ln -sf startup3.wav /var/tmp/portage/gnome-extra/gnome-audio-2.22.1/image///usr/share/sounds/login.wav
ln: creating symbolic link `/var/tmp/portage/gnome-extra/gnome-audio-2.22.1/image///usr/share/sounds/login.wav': No such file or directory
make[1]: *** [install-default-links] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/gnome-extra/gnome-audio-2.22.1/work/gnome-audio-2.22.1/sounds'
make: *** [install] Error 2

(DESTDIR value is not relevant)

This patch fixes it by adding the dependency. Another fix would be to add $(MKINSTALLDIRS) call in this target too.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Vaclav Slavik 2008-04-29 10:02:30 UTC
Created attachment 110102 [details] [review]
patch to fix make install
Comment 2 Bastien Nocera 2008-04-29 16:03:26 UTC
2008-04-29  Bastien Nocera  <hadess@hadess.net>

        * sounds/Makefile: Patch from Vaclav Slavik
        <vslavik@fastmail.fm> to fix "-j2" builds (Closes: #530529)