GNOME Bugzilla – Bug 529925
window placement regression from 2.18 (cascading placement is disabled)
Last modified: 2008-05-15 20:02:04 UTC
Test case : In an empty workspace open new gnome-terminal windows, once the screen is filled with gnome-terminal keep on starting new one the additional gnome-terminals started appear at the top left on the screen. Expected result : The overlapping windows should be cascaded (shifted to the right and bottom by the size of the window frame) Result : The windows are overlapping perfectly making it hard to see directly the new windows are present on the screen. This is a regression compared to metacity 2.18 Evaluation : The cascading algorithm as been disabled in metacity 2.22 (and 2.20). A solution is to default to the cascading algorithm in meta_window_place (place.c) if the no placement algorithm as been applied before. See proposed patch attached. I is ok to commit ?
Created attachment 109915 [details] [review] proposed patch
Thanks for the patch! I'll review it tonight or tomorrow, unless someone else gets there first; sorry, I'm at work at present.
1) It does what it's supposed to and fixes the bug. Wonderful. Thank you. 2) The error was introduced in r3247 by me attempting to fix a xinerama bug. http://svn.gnome.org/viewvc/metacity?rev=3247&view=rev (see call to find_next_cascade) 3) The comment in your patch is slightly broken English: prefer /* If no placement has been done, revert to cascade to avoid * fully overlapping windows (e.g. starting multiple terminals). */ Other than that, go right ahead and check it in.
(PS: If you haven't checked in within the next 24 hours or so I'll check it in, because I want to make a special release for this.)
Checked in: http://svn.gnome.org/viewvc/metacity?rev=3693&view=rev Release imminent.