GNOME Bugzilla – Bug 529794
Implement functions on Gda Easy
Last modified: 2009-01-27 21:36:42 UTC
Please describe the problem: Attached you'll find a PATCH to implement gda_insert_row_into_table, gda_delete_row_from_table, gda_update_value_in_table and gda_update_values_in_table; added some documentation to the sources files and a new gda_statement_new_insert function. The new gda_statement_new_insert function creates a new GdaStatement type INSERT, then you can modify it by getting its 'structure' property, but pay attention that you need to set this property with the modified structure in order to the changes take effect in the GdaStatement object. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
*** Bug 529425 has been marked as a duplicate of this bug. ***
Created attachment 109866 [details] [review] Patch to implement most of Gda Easy missing functions, add some documentation to source code a new function gda_statement_new_insert
Created attachment 109929 [details] [review] This patch implement most of the GdaEasy's functions and add some functions get SUM, AVG, MIN and MAX Adds a convenient function to create a GdaStatement as SELECT function_name (colunm_name) FROM table_name, usefull for functions like SUM, AVG, MIN, MAX, and others.
Created attachment 121762 [details] [review] Patch for Update API and behaivor of gda_prepare_create_table Modification in the gda_perform*'s API in order to avoid gda_prepare* dependencies. Added a GDA_EASY_CREATE_TABLE_NOTHING_FLAG to GdaEasyCreateTableFlag for fields that doesn't have any special flag at table creation time.
*** Bug 558752 has been marked as a duplicate of this bug. ***
Created attachment 121764 [details] [review] Modify GdaEasy function's API and implements References and nothing to CREATE TABLE Same as the 121762 patch but with the prepare_crate_table REFERENCES implementation.
I agree with all the modifications except for the gda_perform_create_database() and gda_perform_drop_database() because one does not always have a GdaConnection to the database to be created or removed (especially when creating a database). So either the API is left as it is now: gda_perform_create_database (GdaServerOperation *op, GError **error); gda_perform_drop_database (GdaServerOperation *op, GError **error); or it can be modified as: gda_perform_create_database (const gchar *provider, GdaServerOperation *op, GError **error); gda_perform_drop_database (const gchar *provider, GdaServerOperation *op, GError **error); where @provider may be NULL if one has already called the corresponding _prepare() function. What do you think?
May be is better da_perform_create_database (const gchar *provider, GdaServerOperation *op, GError **error); gda_perform_drop_database (const gchar *provider, GdaServerOperation *op, GError **error); And @provider must be always set to not NULL in order to get API consistency.
At SVN version 3256, almost all modifications to gda_prepare_create_table aren't applied. Plase refer to PATCH #121764: http://bugzilla.gnome.org/attachment.cgi?id=121764 The change is important due to the actual gda_prepare_create_table doesn't allow to include columns without modificators (a NOTHING flag) and doesn't allow to create foreing keys, with this PATCH even the documentation are modified.
Can I now close the bug?