After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529692 - [goom] fails to build on Windows with mingw32
[goom] fails to build on Windows with mingw32
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 541384 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-24 10:47 UTC by Jesús Corrius
Modified: 2008-07-03 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch to fix the compilation (1.18 KB, patch)
2008-04-24 11:13 UTC, Jesús Corrius
reviewed Details | Review
Proposed patch to fix the compilation 2 (1.71 KB, patch)
2008-04-24 11:29 UTC, Jesús Corrius
committed Details | Review

Description Jesús Corrius 2008-04-24 10:47:17 UTC
While trying to build gst-plugins-good-0.10.8 I get the following error:

c:/dev/build-release/gst-plugins-good-0.10.8/gst/goom/filters.c:217: undefined reference to `random'
c:/dev/build-release/gst-plugins-good-0.10.8/gst/goom/filters.c:218: undefined reference to `random'
.libs/libgstgoom_la-goom_core.o: In function `init_buffers':
c:/dev/build-release/gst-plugins-good-0.10.8/gst/goom/goom_core.c:41: undefined reference to `bzero'
c:/dev/build-release/gst-plugins-good-0.10.8/gst/goom/goom_core.c:43: undefined reference to `bzero'
c:/dev/build-release/gst-plugins-good-0.10.8/gst/goom/goom_core.c:45: undefined reference to `bzero'
Comment 1 Jesús Corrius 2008-04-24 11:13:27 UTC
Created attachment 109814 [details] [review]
Proposed patch to fix the compilation

This is my proposed patch to fix this issue. It works fine in my Windows XP and Vista boxes.
Comment 2 Tim-Philipp Müller 2008-04-24 11:17:34 UTC
Please just change the bzero to memset in the code, or remove the bzero and change the mallocs to callocs.
Comment 3 Tim-Philipp Müller 2008-04-24 11:26:50 UTC
(well, I guess whoever will commit it in the end can do that too, once -good is open for commits again).
Comment 4 Jesús Corrius 2008-04-24 11:29:51 UTC
Created attachment 109815 [details] [review]
Proposed patch to fix the compilation 2

Updated patch
Comment 5 Tim-Philipp Müller 2008-04-25 12:55:19 UTC
Committed, thanks!

 2008-04-25  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Jesús Corrius <jesus at softcatala org>

        * gst/goom/filters.c: (zoomVector):
        * gst/goom/goom_core.c: (init_buffers):
          Fix build with mingw32: use rand() instead of random() and
          replace bzero() with memset(). Fixes #529692.
Comment 6 Sebastian Dröge (slomo) 2008-07-03 19:31:47 UTC
*** Bug 541384 has been marked as a duplicate of this bug. ***