After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529546 - [Playbin] Memory leak in streaminfo handling
[Playbin] Memory leak in streaminfo handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-23 13:59 UTC by Tommi Myöhänen
Modified: 2008-04-24 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
removed obsolete code (1.06 KB, patch)
2008-04-24 06:39 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Tommi Myöhänen 2008-04-23 13:59:36 UTC
The code below could be removed from setup_sinks() as it does nothing and it seems the "object" should be unreffed in order to avoid leaked reference:

  /* now actually connect everything */
  g_object_get (G_OBJECT (play_base_bin), "stream-info", &streaminfo, NULL);
  for (s = streaminfo; s; s = g_list_next (s)) {
    GObject *obj = G_OBJECT (s->data);
    gint type;
    GstObject *object;

    g_object_get (obj, "type", &type, NULL);
    g_object_get (obj, "object", &object, NULL);
  }
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-04-24 06:39:46 UTC
Created attachment 109806 [details] [review]
removed obsolete code
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-04-24 08:20:31 UTC
2008-04-24  Stefan Kost  <ensonic@users.sf.net>

	* gst/playback/gstplaybin.c:
	  Remove obsolete streaminfo code and fix a leak. Fixes #529546