After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529454 - [udpsrc] generates false error on win32 due to ICMP dest-unreachable message
[udpsrc] generates false error on win32 due to ICMP dest-unreachable message
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal major
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-22 23:08 UTC by Youness Alaoui
Modified: 2008-05-01 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the WSAECONNRESET error on udpsrc on Windows (750 bytes, patch)
2008-04-22 23:12 UTC, Youness Alaoui 		none Details | Review
updated patch: don't leak pktdata when retrying; mention socket error code in error message / log on win32 (1.36 KB, patch)
2008-04-29 17:47 UTC, Tim-Philipp Müller 		committed Details | Review

Description Youness Alaoui 2008-04-22 23:08:39 UTC 
Hi,
udpsrc on Windows can generate a false error. When sending a packet with udpsink, if the remote ip/port is unreachable, we receive an ICMP response with "port unreachable"... the corresponding udpsrc will then return an error on the recvfrom and WSAGetLastError will return WSAECONNRESET. That error is not checked (actually errors from recvfrom do not check WSAGetLastError at all). 
The correct behavior would be to ignore the WSAECONNRESET and retry to recv a packet instead of throwing an error.
Comment 1 Youness Alaoui 2008-04-22 23:12:02 UTC 
Created attachment 109729 [details] [review]
Patch to fix the WSAECONNRESET error on udpsrc on Windows
Comment 2 Tim-Philipp Müller 2008-04-29 17:47:36 UTC 
Created attachment 110121 [details] [review]
updated patch: don't leak pktdata when retrying; mention socket error code in error message / log on win32
Comment 3 Tim-Philipp Müller 2008-05-01 10:52:20 UTC 
Committed, thanks:

  2008-05-01  Tim-Philipp Müller  <tim.muller at collabora co uk>

        Patch by: Youness Alaoui <youness.alaoui at collabora co uk>

        * gst/udp/gstudpsrc.c: (gst_udpsrc_create):
          Don't error out if we get an ICMP destination-unreachable
          message when trying to read packets on win32 (#529454).