After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528868 - URI schemes/protocols should be handled case insensitive
URI schemes/protocols should be handled case insensitive
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal major
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-19 07:39 UTC by Sebastian Dröge (slomo)
Modified: 2008-04-19 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2008-04-19 07:39:57 UTC
Hi,
as Alp Toker pointed out on IRC URI schemes should be handled case insensitive but all URI schemes we return should be lower case:

<alp>    specify schemes must do so with lowercase letters.  An implementation
<alp>    should accept uppercase letters as equivalent to lowercase in scheme
<alp>    names (e.g., allow "HTTP" as well as "http") for the sake of
<alp>    robustness but should only produce lowercase scheme names for
<alp>    consistency.
<alp> section 3.1 of RFC 3986

Not sure which code this bug affects, at least filesrc and filesink do a case sensitive check for "file".
Comment 1 Edward Hervey 2008-04-19 12:03:55 UTC
this would affect gst/gsturi.c and wouldn't break API as far as I can think.
Comment 2 Sebastian Dröge (slomo) 2008-04-19 15:35:56 UTC
2008-04-19  Sebastian Dröge  <slomo@circular-chaos.org>

	* gst/gsturi.c: (gst_uri_protocol_check_internal),
	(gst_uri_get_protocol), (gst_uri_has_protocol),
	(gst_uri_construct), (gst_uri_handler_set_uri):
	A valid URI scheme can also include '+', '-' and '.' additional
	to alphanumeric characters as per RFC 3986 Section 3.1.

	Handle URI schemes case insensitive in all places and convert
	to lower-case when constructing an URI or setting an URI with
	the GstURIHandler interface. Fixes bug #528868.
	All elements can still assume (as before) that they will
	get passed URIs with a lower-case URI scheme by the GstURIHandler
	interface.