After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528814 - RB should use podcast date and time when transferring to iPod
RB should use podcast date and time when transferring to iPod
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: iPod
0.11.x
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-18 20:20 UTC by Niels Vorgaard Christensen
Modified: 2008-06-15 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update time_released field in podcast tracks (578 bytes, patch)
2008-04-18 20:23 UTC, Niels Vorgaard Christensen
needs-work Details | Review
Proposed patch (1.27 KB, patch)
2008-04-25 12:25 UTC, Niels Vorgaard Christensen
none Details | Review
Updated patch against SVN 5747 (1.32 KB, patch)
2008-06-15 08:45 UTC, Paul Drain
none Details | Review

Description Niels Vorgaard Christensen 2008-04-18 20:20:44 UTC
Please describe the problem:
The RB database contains the date and time of the release of a podcast. This information should be used when the podcast is transferred to an iPod.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Niels Vorgaard Christensen 2008-04-18 20:23:38 UTC
Created attachment 109508 [details] [review]
Update time_released field in podcast tracks

Something like this seems to work just fine.
Comment 2 Bastien Nocera 2008-04-19 10:21:28 UTC
Looks good, but you should use a temporary variable.
Comment 3 Niels Vorgaard Christensen 2008-04-25 12:25:18 UTC
Created attachment 109902 [details] [review]
Proposed patch

Actually the itdb_time_* functions are obsoleted. This patch both answers the last comment and removes other itdb_time_* calls from create_ipod_song_from_entry().
Comment 4 Paul Drain 2008-06-15 08:45:43 UTC
Created attachment 112766 [details] [review]
Updated patch against SVN 5747

No functional changes, just updated for a more recent SVN.
Comment 5 Christophe Fergeau 2008-06-15 12:55:19 UTC
Fixed in svn r5753, I didn't take the removal of the itdb_time functions since it should be done on the whole file imo, and anyway these functions are doing nothing these days, so it's no big deal if they are still there :)