After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528675 - media handling, open folder issues
media handling, open folder issues
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-18 01:53 UTC by Matthias Clasen
Modified: 2008-06-29 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.26 KB, patch)
2008-04-18 02:32 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2008-04-18 01:53:09 UTC
When I select "Open folder" as the action for photos and plug in my camera,
the folder only opens if I additionally check the "Browse media" checkbox.

This is confusing, imo. An explicit choice of "Open folder" should work, independently of the "Browse media" checkbox.

The problem is that autorun_guessed_content_type_callback calls autorun_open_folder_for_mount to open the folder, and makes no difference between explicit and fallback. In the explicit case, we should directly open the window, and not go via autorun_open_folder_for_mount, since that function checks the "Browse media" setting.
Comment 1 Matthias Clasen 2008-04-18 02:32:38 UTC
Created attachment 109464 [details] [review]
proposed patch
Comment 2 David Zeuthen (not reading bugmail) 2008-04-18 02:35:03 UTC
Looks good to me, thanks for tracking this down.
Comment 3 Cosimo Cecchi 2008-04-18 08:16:21 UTC
Setting patch status.
Comment 4 André Klapper 2008-06-15 12:34:10 UTC
can we please commit this?
Comment 5 Cosimo Cecchi 2008-06-15 18:43:03 UTC
I committed the patch. Closing as FIXED.

2008-06-15  Cosimo Cecchi  <cosimoc@gnome.org>

	reviewed by: David Zeuthen <david@fubar.dk>

	* libnautilus-private/nautilus-autorun.c:
	Always open folder if the corresponding action is selected
	in the autorun preferences.
	Patch by Matthias Clasen. (#528675).
Comment 6 Gilles Dartiguelongue 2008-06-29 22:15:40 UTC
fixing patch status.