After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528266 - [ofa] Unit test fails because of different fingerprints
[ofa] Unit test fails because of different fingerprints
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-15 17:50 UTC by Sebastian Dröge (slomo)
Modified: 2008-04-16 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ofa-check.diff (3.52 KB, patch)
2008-04-15 17:59 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2008-04-15 17:50:42 UTC
The ofa unit test currently fails on different architectures because the fingerprints are different than the expected ones. Also they're different for big endian and little endian data currently.

This seems to be no problem, the fingerprint still works properly, but I don't see a way to check the fingerprint in the unit test. Maybe the fingerprint should just be checked for validity...
Comment 1 Sebastian Dröge (slomo) 2008-04-15 17:59:55 UTC
Created attachment 109325 [details] [review]
ofa-check.diff

Only check if the fingerprint is valid base64
Comment 2 Jan Schmidt 2008-04-16 09:38:58 UTC
hrmn, I'd rather fix the FIXMEs, but we can do that later once we figure out why it's producing different fingerprints.
Comment 3 Sebastian Dröge (slomo) 2008-04-16 09:47:52 UTC
2008-04-16  Sebastian Dröge  <slomo@circular-chaos.org>

	* tests/check/elements/ofa.c: (bus_handler), (GST_START_TEST):
	Only check if the generated fingerprints are valid Base64. The
	fingerprints are different when running on different architectures
	which is a) no problem because the fingerprints are tolerant enough
	and b) is caused by libofa. Fixes bug #528266.