After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528150 - Seahorse fails to import keys
Seahorse fails to import keys
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.22.x
Other Linux
: Normal normal
: 2.22.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
: 404034 493950 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-15 04:54 UTC by Andrew Starr-Bochicchio
Modified: 2008-05-05 01:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Andrew Starr-Bochicchio 2008-04-15 04:54:26 UTC
Reported on Launchpad:
https://bugs.edge.launchpad.net/ubuntu/+source/seahorse/+bug/215729

"Steps to reproduce:
1. Open Seahorse (Applications -> Accessories -> Passwords and Encryption Keys)
2. Click "Find Remote Keys"
3. Search for someone....even someone random
4. Pick a key from the list returned
5. Hit either the big "Import" button or go to Key -> Import

What happens:
Nothing

What should happen:
Public key should be downloaded and added to keyring"
Comment 1 Andrew Starr-Bochicchio 2008-04-15 04:56:18 UTC
I have tested this patch and can confirm it resolves this issue.

Patch to resolve this issue by Mackenzie Morgan on Launchpad:

http://launchpadlibrarian.net/13404149/seahorse-hkp-source.c.diff

Comment 2 Adam Schreiber 2008-04-15 13:29:22 UTC
Could you give a concrete example?  I've built trunk on Ubuntu Hardy and searched for 'zimmerman' on pgp.mit.edu and was able to successfully import the key.
Comment 3 Andrew Starr-Bochicchio 2008-04-15 17:01:28 UTC
This was occurring with any name I tried using 2.22.1-0ubuntu1. The keys are found and displayed, but never show up under the Other Collected Keys tab after selecting import. I never experienced this issue with the 2.21.X series.
Comment 4 Andrew Starr-Bochicchio 2008-04-16 03:30:39 UTC
From Steve Langasek on Launchpad:

"The proposed patch has a memory leak. Attached is a revised patch that fixes the memory management issues; can someone test that it also fixes the problem?"

Updated patch: http://launchpadlibrarian.net/13480676/seahorse-hex-key-import.debdiff

I can confirm that this patch also resolves the issue. 
Comment 5 Adam Schreiber 2008-04-17 13:41:15 UTC
(In reply to comment #2)
> Could you give a concrete example?  

I'm serious that I can't replicate this problem.  Please let me know exactly which key fails for you, how you are searching (name, email, hex id, etc.) and on which server.

Comment 6 Andrew Starr-Bochicchio 2008-04-17 15:46:41 UTC
OK... Searching the name "Adam Schreiber" on the following key servers:

hkp://pgp.mit.edu:11371
ldap://keyserver.pgp.com
hkp://keyserver.ubuntu.com:11371

A total of six keys are displayed, three different keys two times each. None of the six keys are imported to the Other Collected Keys tab after highlighting them and selecting Import from toolbar one at a time. The fourth of the six keys is the only one that displays any info as to whether or not Seahorse is trying to do anything. A dialog appears with a progress bar reporting that the key was being downloaded from pgp.mit.edu:11371, yet it never shows up in the Other Collected Keys tab.

Neither I am able to select the key and use the Save Key As button to save it to my desktop and then import locally. A file "Adam Schreiber.asc" is created, but contains no data at all.

The same can be repeated with any name or email address.

The above patch resolves this issue for me. All actions produce expected results.
Comment 7 Adam Schreiber 2008-04-17 16:18:07 UTC
Committed to trunk and branches/gnome-2-22.  Thanks.  I must have had some other changes floating around my source tree and needed a clean check out.

2008-04-17  Adam Schreiber  <sadam@clemson.edu>

    * libseahorse/seahorse-hkp-source.c: Fix importing keys from hkp keyservers.
    Patch from Mackenzie Morgan.  Fixes bug #528150
Comment 8 Adam Schreiber 2008-05-05 01:25:54 UTC
*** Bug 493950 has been marked as a duplicate of this bug. ***
Comment 9 Adam Schreiber 2008-05-05 01:26:53 UTC
*** Bug 404034 has been marked as a duplicate of this bug. ***