After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528091 - Arrows for scrollable notebooks don't work with unset GTK_CAN_FOCUS on notebook
Arrows for scrollable notebooks don't work with unset GTK_CAN_FOCUS on notebook
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 386880 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-04-14 19:04 UTC by Milan Crha
Modified: 2008-08-20 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed gtk+ patch (1.49 KB, patch)
2008-04-14 20:15 UTC, Milan Crha
needs-work Details | Review
proposed gtk+ patch ][ (1.33 KB, patch)
2008-08-05 08:33 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2008-04-14 19:04:43 UTC
Subject says it all, when I unset GTK_CAN_FOCUS on the notebook itself and have this set as scrollable and make window as small as I can see and touch arrows on the left and right side of the tabs, then I can click on them as much as I want, but it will not change actual tab at all.
Comment 1 Milan Crha 2008-04-14 20:15:07 UTC
Created attachment 109261 [details] [review]
proposed gtk+ patch

for gtk+;

I thought about something like this. It should work fine I guess, even I've such a feeling you'll consider some parts of this patch as unnecessary.
Comment 2 Reinout van Schouwen 2008-08-01 21:01:36 UTC
Is this a duplicate of bug 386880 ?
Comment 3 Milan Crha 2008-08-04 08:17:44 UTC
Yes, you've right, it is. And I can reproduce it without the above patch.
Comment 4 Reinout van Schouwen 2008-08-04 11:19:27 UTC
*** Bug 386880 has been marked as a duplicate of this bug. ***
Comment 5 Björn Lindqvist 2008-08-04 22:37:06 UTC
Instead of adding an additional code path for the not-focusable case, it would be better if the both paths were merged. I also think you can call the gtk_notebook_change_current_page to change the page instead of figuring out what the next page is yourself. Maybe emitting the change-current-page signal could also work.
Comment 6 Milan Crha 2008-08-05 08:33:56 UTC
Created attachment 115878 [details] [review]
proposed gtk+ patch ][

for gtk+;

Ahh, I see, this is much simpler. I tested the old and new behaviour and I do not see any change with the patch applied (except of the functionality on non-focusable notebooks).
Comment 7 Björn Lindqvist 2008-08-19 21:11:03 UTC
Patch applies and appears to work fine. Please commit.
Comment 8 Tomas Bzatek 2008-08-20 08:18:41 UTC
Committed to trunk, revision 21170.

2008-08-05  Milan Crha  <mcrha@redhat.com> 

        * gtk/gtknotebook.c: (gtk_notebook_do_arrow): Allow changing page with
        arrows even on non-focusable notebook. (#528091)
Comment 9 Björn Lindqvist 2008-08-20 18:28:59 UTC
Great. But please remember to update the date of the ChangeLog entry next time.