GNOME Bugzilla – Bug 528091
Arrows for scrollable notebooks don't work with unset GTK_CAN_FOCUS on notebook
Last modified: 2008-08-20 18:28:59 UTC
Subject says it all, when I unset GTK_CAN_FOCUS on the notebook itself and have this set as scrollable and make window as small as I can see and touch arrows on the left and right side of the tabs, then I can click on them as much as I want, but it will not change actual tab at all.
Created attachment 109261 [details] [review] proposed gtk+ patch for gtk+; I thought about something like this. It should work fine I guess, even I've such a feeling you'll consider some parts of this patch as unnecessary.
Is this a duplicate of bug 386880 ?
Yes, you've right, it is. And I can reproduce it without the above patch.
*** Bug 386880 has been marked as a duplicate of this bug. ***
Instead of adding an additional code path for the not-focusable case, it would be better if the both paths were merged. I also think you can call the gtk_notebook_change_current_page to change the page instead of figuring out what the next page is yourself. Maybe emitting the change-current-page signal could also work.
Created attachment 115878 [details] [review] proposed gtk+ patch ][ for gtk+; Ahh, I see, this is much simpler. I tested the old and new behaviour and I do not see any change with the patch applied (except of the functionality on non-focusable notebooks).
Patch applies and appears to work fine. Please commit.
Committed to trunk, revision 21170. 2008-08-05 Milan Crha <mcrha@redhat.com> * gtk/gtknotebook.c: (gtk_notebook_do_arrow): Allow changing page with arrows even on non-focusable notebook. (#528091)
Great. But please remember to update the date of the ChangeLog entry next time.