GNOME Bugzilla – Bug 527999
[goom] Doesn't dist goomsl.h
Last modified: 2008-04-16 10:42:12 UTC
Hi, goom in the latest pre-release fails to build because goomsl.h is not disted. Attached patch fixes this... [...] cc -DHAVE_CONFIG_H -I. -I. -I../.. -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/liboil-0.3 -DBUILD_MMX -g -O2 -g -Wall -O2 -c goomsl_lex.c -fPIC -DPIC -o .libs/libgstgoomconfigparse_la-goomsl_lex.o ./goomsl_lex.l:6:20: error: goomsl.h: Datei oder Verzeichnis nicht gefunden In file included from ./goomsl_lex.l:7: goomsl_private.h:69: error: expected specifier-qualifier-list before ‘GoomHash’ goomsl_private.h:104: error: expected specifier-qualifier-list before ‘GoomSL’ goomsl_private.h:126: error: expected specifier-qualifier-list before ‘GoomHash’ goomsl_private.h:142: error: expected specifier-qualifier-list before ‘GoomSL_ExternalFunction’ goomsl_private.h:172: error: expected specifier-qualifier-list before ‘GoomHash’ goomsl_private.h:196: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token goomsl_private.h:198: error: expected ‘)’ before ‘*’ token goomsl_private.h:200: error: expected declaration specifiers or ‘...’ before ‘GoomHash’ goomsl_private.h:205: error: expected ‘)’ before ‘*’ token goomsl_private.h:208: error: expected ‘)’ before ‘*’ token goomsl_private.h:209: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token goomsl_private.h:210: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token In file included from ./goomsl_lex.l:8: ./goomsl_yacc.y:1235: error: expected specifier-qualifier-list before ‘GoomHash’ ./goomsl_lex.l:12: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token ./goomsl_lex.l: In function ‘yylex’: ./goomsl_lex.l:27: error: ‘currentGoomSL’ undeclared (first use in this function) ./goomsl_lex.l:27: error: (Each undeclared identifier is reported only once ./goomsl_lex.l:27: error: for each function it appears in.) ./goomsl_lex.l:51: warning: implicit declaration of function ‘gsl_malloc’ make[4]: *** [libgstgoomconfigparse_la-goomsl_lex.lo] Fehler 1 make[4]: Leaving directory `/home/slomo/projects/debian/pkg-gstreamer/unstable/build-area/gst-plugins-good0.10-0.10.7.2/gst/goom'
Created attachment 109220 [details] [review] goom-makefile.diff
Created attachment 109228 [details] [review] remove flex and bison dependency Or we could just remove all the bison/flex stuff, since it's not needed at all anyway. This would remove the following files in addition to the modifications in the patch: R default_scripts.h R goomsl.c R goomsl.h R goomsl_hash.c R goomsl_hash.h R goomsl_heap.c R goomsl_heap.h R goomsl_private.h
(Patch contains unrelated bit in convolve_fx.c, ignore that please).
What exactly is the bison/flex stuff used for in goom? But if it's completely uneeded we should really remove it.
As far as I know, the bison/flex stuff is something to do with loading config files to customise the behaviour of the goom instance. I don't think we've supplied an interface by which users can access that, so it'd make sense either do so, or strip it out. I'm in favour of stripping it out.
Seems a bit elaborate for a simple config file reader, but if it is we could probably expose the config options without it. If it's more than just that, e.g. some kind of scripting engine, I don't really see us exposing or maintaining that either, so let's just get rid of it all.
Yeah, I think it provides a scripting engine. Strip it out, I say.
Your wish is my command: 2008-04-16 Tim-Philipp Müller <tim at centricular dot net> * configure.ac: * gst/goom/Makefile.am: * gst/goom/convolve_fx.c: * gst/goom/default_scripts.h: * gst/goom/goom.h: * gst/goom/goom_core.c: (choose_a_goom_line): * gst/goom/goom_plugin_info.h: * gst/goom/goomsl.c: * gst/goom/goomsl.h: * gst/goom/goomsl_hash.c: * gst/goom/goomsl_hash.h: * gst/goom/goomsl_heap.c: * gst/goom/goomsl_heap.h: * gst/goom/goomsl_private.h: * gst/goom/plugin_info.c: Strip out the config/script parsing stuff, we don't need it. Fixes #527999.