GNOME Bugzilla – Bug 527412
Port the MiniMode to the new code base
Last modified: 2008-05-01 13:32:48 UTC
Here's a patch to bring the MiniMode plugin to the new codebase. It could probably use a bit more testing, but it looks OK.
Created attachment 109020 [details] [review] The MiniMode patch
Running automake --gnu --add-missing --force --copy -Wno-portability -Wno-portability ... src/Extensions/Banshee.NotificationArea/Makefile.am:3: NOTIFY_SHARP_LIBS was already defined in condition TRUE, which includes condition EXTERNAL_NOTIFY_SHARP ... configure.ac:59: ... `NOTIFY_SHARP_LIBS' previously defined here src/Extensions/Banshee.NotificationArea/Makefile.am:6: NOTIFY_SHARP_LIBS was already defined in condition TRUE, which includes condition !EXTERNAL_NOTIFY_SHARP ... configure.ac:59: ... `NOTIFY_SHARP_LIBS' previously defined here src/Extensions/Banshee.NotificationArea/Makefile.am:2: variable `NOTIFY_SHARP_SOURCES' is defined but no program or src/Extensions/Banshee.NotificationArea/Makefile.am:2: library has `NOTIFY_SHARP' as canonic name (possible typo) configure.ac:97: required file `src/Extensions/Banshee.MiniMode/Makefile.in' not found Error: Could not run automake, which is required to configure banshee cd . && /bin/sh /home/nx/code/svn/gnome/banshee-trunk/missing --run automake-1.9 --gnu src/Extensions/Banshee.NotificationArea/Makefile.am:3: NOTIFY_SHARP_LIBS was already defined in condition TRUE, which includes condition EXTERNAL_NOTIFY_SHARP ... configure.ac:59: ... `NOTIFY_SHARP_LIBS' previously defined here src/Extensions/Banshee.NotificationArea/Makefile.am:6: NOTIFY_SHARP_LIBS was already defined in condition TRUE, which includes condition !EXTERNAL_NOTIFY_SHARP ... src/Extensions/Banshee.NotificationArea/Makefile.am:3: ... `NOTIFY_SHARP_LIBS' previously defined here src/Extensions/Banshee.NotificationArea/Makefile.am:2: variable `NOTIFY_SHARP_SOURCES' is defined but no program or src/Extensions/Banshee.NotificationArea/Makefile.am:2: library has `NOTIFY_SHARP' as canonic name (possible typo) configure.ac:97: required file `src/Extensions/Banshee.MiniMode/Makefile.in' not found => Makefile.in missing and something is not right with NOTIFY_SHARP_LIBS
I can't reproduce this problem. Did you run "autogen.sh" after applying the patch ? Makefile.in should be generated by automake. Most of the errors seems to be about NotificationArea and notify-sharp. I don't have notify-sharp on my system, do you ?
(In reply to comment #3) > Did you run "autogen.sh" Yes, as you see from the output above (the automake part is failing) > I don't have notify-sharp on my system, do you ? No... and I don't see those src/Extensions/Banshee.NotificationArea related errors without your patch :/ but I can't really see what part of the patch could cause this, you don't even touch Banshee.NotificationArea...
Created attachment 109069 [details] [review] The fixed MiniMode patch A new version of the patch that should fix your issue. The previous one was missing the "src/Extensions/Banshee.MiniMode/Makefile.am" file. Sorry about this. I blame automake for the nonsensical error messages that were caused by this...
Just tested this new patch. It builds this time :) Seems to work as expected, too. Only problem I found so far is that I can't seem to switch to playlists in mini mode. Also try this: start banshee and without starting playback, go to the mini mode. Here, select a playlist and press play. The window will freeze and nothing happens. Besides this it seems to work well. A general question: there has been interest in a muine-like UI for banshee by some. Perhaps doing this as part as a minimode revamp would be a good idea? Minimode should at least have a track list area anyway (to show playlists etc) and the only thing Muine has besides this is a button which opens a search/album window IIRC.
Created attachment 109130 [details] [review] The MiniMode patch v3 Thanks for the feedback. This new version of the patch includes a one line addition that should fix the issues you noticed : selecting a source in MiniMode now also sets it as the current playback source. It also fixes the dependencies in the .addin.xml file.
Thanks for your work! A few more problems: 1.) Starting the initial playback after selecting a playlist works now, but starting playback from the library (just start banshee->minimode->play) does not (or, no longer?). Banshee freezes with "Querying model for track to play in Linear:Next mode" 2.) Selecting the podcast source or any last.fm station produces the same result as 1.) 3.) selecting the "Now playing" or "Last.fm" sources in mini mode crashes banshee. Those can't be used for playback anyway, so, can you hide them? After those bugs are fixed the extension could be included in trunk IMHO. Even if this is not going to evolve into a Muine GUI, having last.fm voting buttons accessible from minimode would be very nice as minimode would make a nice last.fm player interface.
Created attachment 109258 [details] [review] The MiniMode patch v4 This new version of the patch should fix the crashes you described in 3.). But the behavior is probably not right (see below). I haven't been able to consistently reproduce your issue described in 1.). It happened only one time out of 10, for no apparent reason. I agree that there are some sources that don't make much sense in the MiniMode : "Now Playing", video stuff, the Last.fm main source, and maybe some others. I'm not sure how to detect those, and what to do with them : not put them in the combo ? Grey them out ? I'd be happy to hear any suggestions.
Sorry for taking so long to review this and get it in, Bertrand. I've committed it. With respect to Now Playing, it probably should be visible in minimode - it would make it not so mini, but if you're watching a video, mini-mode obviously needs to show you it. Any way, thanks for your work!