After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 527271 - Ctrl-Q should quit file-roller
Ctrl-Q should quit file-roller
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.18.x
Other All
: Normal minor
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2008-04-10 03:05 UTC by Michael Gauthier
Modified: 2008-06-02 16:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Adds support for (hidden) Ctrl-Q in file-roller (700 bytes, patch)
2008-06-01 13:33 UTC, Eric Piel
none Details | Review

Description Michael Gauthier 2008-04-10 03:05:07 UTC
Ctrl-Q should quit file-roller. Most other Gnome applications (Gedit, Character Map, Evolution, Calculator, games, etc) use Ctrl-Q to quit. File Roller uses Ctrl-W.

Other information:
Comment 1 Eric Piel 2008-06-01 12:00:45 UTC
Hi,
I disagree with this bug report: File-roller uses Ctrl-W to "Close" the archive, and not to quit the application (the main difference being if you have several archives opened at the same time). So this is conform with the gnome HIG http://library.gnome.org/devel/hig-book/stable/menus-standard.html.en

One could regret still that pressing Ctrl-Q does nothing. I would suggest to either add another entry to the menu for closing the application (but that would probably clutter the menu for not much usefulness) or, better, to add a "hidden" accelerator Ctrl-Q which does quit the whole application (useful for power-users who know by heart the shortcuts).
Comment 2 Eric Piel 2008-06-01 13:33:13 UTC
Created attachment 111887 [details] [review]
Adds support for (hidden) Ctrl-Q in file-roller

Here is my implementation for the proposal to support Ctrl-Q (without menu entry, so just for power users). The patch is against svn trunk.
Comment 3 Paolo Bacchilega 2008-06-02 16:52:31 UTC
Eric,

I've modified your patch to close the window instead of quitting the application, so basically now Ctrl-Q and Ctrl-W do the same thing.

Thanks.