GNOME Bugzilla – Bug 527210
[PATCH] Build failure if ggz-gtk-client exists in system.
Last modified: 2012-01-31 23:29:38 UTC
The gnome-games (gnect, gnibbles and iagno) get build failures if ggz-gtk-client exists in system. The three Makefile.am need to reorder the -I/path/to of GNOME_GAMES_CFLAGS, GGZMOD_INCLUDES, and GGZ_GTK_INCLUDES to get build success. The GGZ_GTK_INCLUDES should be comes in first before GNOME_GAMES_CFLAGS and GGZMOD_INCLUDES. Because the GNOME_GAMES_CFLAGS and GGZMOD_INCLUDES have -I/usr/local/include and will find ggz-gtk-client's header files in system. Here are the before and after build logs of iagno (gnect and gnibbles get same error). Before: ==================================================== if cc -DHAVE_CONFIG_H -I. -I. -I.. -I../libgames-support -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -std=gnu89 -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include [..snip..] -DDATADIR=\""/usr/local/share"\" -DGNOMELOCALEDIR=\""/usr/local/share/locale"\" -I /usr/local/include -I../dependencies/ggz-gtk -I /usr/local/include [..snip..] ggz-network.c; \ then mv -f ".deps/ggz-network.Tpo" ".deps/ggz-network.Po"; else rm -f ".deps/ggz-network.Tpo"; exit 1; fi ggz-network.c: In function 'on_network_game': ggz-network.c:315: error: too many arguments to function 'ggz_gtk_initialize' gmake[3]: *** [ggz-network.o] Error 1 gmake[3]: Leaving directory `/usr/home/mezz/commit/gnome-games/work/gnome-games-2.22.1.1/iagno' ==================================================== After: ==================================================== if cc -DHAVE_CONFIG_H -I. -I. -I.. -I../libgames-support -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -DDATADIR=\""/usr/local/share"\" -DGNOMELOCALEDIR=\""/usr/local/share/locale"\" -I../dependencies/ggz-gtk -I /usr/local/include -I /usr/local/include -std=gnu89 -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include [..snip..] ggz-network.c; \ then mv -f ".deps/ggz-network.Tpo" ".deps/ggz-network.Po"; else rm -f ".deps/ggz-network.Tpo"; exit 1; fi /bin/sh ../libtool --tag=CC [..goes on successed to build..] ====================================================
Created attachment 108949 [details] [review] Reorder the -I/path/to in Makefile.am to get build sccess.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=7628
This bug is being reassigned to the "general" component so we can close the ggz bugzilla component. Apologies for the mass email!