After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526905 - [musepack] Port to the new libmpcdec API
[musepack] Port to the new libmpcdec API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.8
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-08 11:04 UTC by Sebastian Dröge (slomo)
Modified: 2008-04-24 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpc-sv8.diff (11.37 KB, patch)
2008-04-16 10:41 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-04-08 11:04:08 UTC 
Hi,
the new libmpc found at http://svn.musepack.net/libmpc/trunk/ which also support stream version 8 has a new API that is completely incompatible with what we currently have it seems.

We should probably port the plugin soonish as the first release of libmpc should be soon.
Comment 1 Sebastian Dröge (slomo) 2008-04-16 10:41:28 UTC 
Created attachment 109362 [details] [review]
mpc-sv8.diff
Comment 2 Sebastian Dröge (slomo) 2008-04-16 10:42:03 UTC 
I'll commit this after the freeze...
Comment 3 Sebastian Dröge (slomo) 2008-04-24 22:18:44 UTC 
2008-04-25  Sebastian Dröge  <slomo@circular-chaos.org>

        * configure.ac:
        * ext/musepack/gstmusepackdec.c: (gst_musepackdec_base_init),
        (gst_musepackdec_init), (gst_musepackdec_dispose),
        (gst_musepackdec_handle_seek_event), (gst_musepack_stream_init),
        (gst_musepackdec_loop), (plugin_init):
        * ext/musepack/gstmusepackdec.h:
        * ext/musepack/gstmusepackreader.c:
        * ext/musepack/gstmusepackreader.h:
        Add support for the new libmpcdec API which magically gets us support
        for SV8 files. Also do some random cleanup. Fixes bug #526905.