After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526770 - Compositor can no longer be disabled
Compositor can no longer be disabled
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: Iain's compositor
trunk
Other Linux
: Normal critical
: ---
Assigned To: Metacity compositor maintainers
Metacity compositor maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-07 17:22 UTC by Thomas Thurman
Modified: 2008-05-24 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backported patch (1.86 KB, patch)
2008-04-07 22:43 UTC, iain
none Details | Review

Description Thomas Thurman 2008-04-07 17:22:09 UTC
On trunk, if the compositor is running, turning it off in gconf will cause the screen to cease updating.  Metacity is still running, but nothing will change onscreen.  metacity --replace will solve the problem.

This was reported on Lauchpad (<https://bugs.launchpad.net/bugs/213401>) but that bug was closed for procedural reasons.

Initial investigation shows that meta_compositor_unmanage_screen is correctly called.  I suspect that the change is due to the way shadowed windows are handled from r3653 (<http://svn.gnome.org/viewvc/metacity?rev=3653&view=rev>).

2.22 tarballs go out tonight and I'd like to backport this to 2.22 if necessary then.  We may have to do the sad teddy bear thing again if necessary.
Comment 1 iain 2008-04-07 22:30:25 UTC
its nothing to do with that commit.
Its never actually worked very well.
X seems to have issues with compositing being turned off? xcompmgr doesn't do it well either.
I have a partial fix, because the compositor overlay window isn't being released, so that window remains at the top, but after that X gets all screwy.

I'll commit my partial fix that releases the overlay window, but its honestly not worth reverting to a previous commit that still didn't work.
Comment 2 iain 2008-04-07 22:43:15 UTC
Created attachment 108824 [details] [review]
backported patch

Backported patch that hides the COW window when unmanaging the screen
Also backports the speed increase by using an idle instead of a timeout
Comment 3 iain 2008-05-24 11:10:45 UTC
This has been fixed in trunk and I guess 2.22 went out ages ago so I committed this patch to the 2.22 branch.