After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526761 - Make mail indexing modular
Make mail indexing modular
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jamie McCracken
Jamie McCracken
Depends on:
Blocks: 529520
 
 
Reported: 2008-04-07 16:48 UTC by Carlos Garnacho
Modified: 2010-05-17 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Make mail indexer modular. (44.89 KB, patch)
2008-04-07 16:49 UTC, Carlos Garnacho 		committed Details | Review
Fixes a problem in this patch (406 bytes, patch)
2008-04-08 11:43 UTC, Philip Van Hoof 		none Details | Review

Description Carlos Garnacho 2008-04-07 16:48:08 UTC 
The scenario where a single user wants to enable indexing for several mail clients at the same time won't be very usual, so it makes sense to make mail indexing modular, having just the module for the preferred mail client loaded. I'm going to attach a patch to do that
Comment 1 Carlos Garnacho 2008-04-07 16:49:55 UTC 
Created attachment 108794 [details] [review]
[PATCH] Make mail indexer modular.

 INSTALL                                  |   53 ++++++-----
 src/libtracker-common/tracker-config.c   |  147 ++++++-----------------------
 src/libtracker-common/tracker-config.h   |   12 +--
 src/trackerd/Makefile.am                 |   29 +++++-
 src/trackerd/tracker-dbus-methods.c      |    5 +-
 src/trackerd/tracker-email-evolution.c   |   50 +++++++----
 src/trackerd/tracker-email-evolution.h   |   44 ---------
 src/trackerd/tracker-email-kmail.c       |   42 +++++----
 src/trackerd/tracker-email-kmail.h       |   44 ---------
 src/trackerd/tracker-email-thunderbird.c |   49 +++++-----
 src/trackerd/tracker-email-thunderbird.h |   46 ---------
 src/trackerd/tracker-email-utils.c       |    3 -
 src/trackerd/tracker-email.c             |  128 ++++++++++++++------------
 src/trackerd/tracker-email.h             |   13 ++-
 src/trackerd/tracker-process-files.c     |   52 ++---------
 src/trackerd/trackerd.c                  |   24 +----
 16 files changed, 260 insertions(+), 481 deletions(-)
Comment 2 Carlos Garnacho 2008-04-07 16:51:46 UTC 
Hrm, sorry, the INSTALL file was modified automatically by autofoo, I didn't notice when submitting
Comment 3 Jamie McCracken 2008-04-07 17:19:34 UTC 
Patch looks ok - feel free to commit

thanks
Comment 4 Philip Van Hoof 2008-04-07 17:55:05 UTC 
Sidenote, related to this patch:

In the Patch for Modest's support we can see that there are still a few more files other than the files being compiled/linked into the Module that need to be edited for supporting a new E-mail client.

Ideally after this patch would tracker allow the creation of just a module to start supporting a new E-mail client.

http://mail.gnome.org/archives/tracker-list/2008-April/msg00022.html

For example search for "modest-open" to find where the launcher is to be specified. The same setting is stored hard-coded at ~ 4 locations.
Comment 5 Philip Van Hoof 2008-04-08 11:43:31 UTC 
Created attachment 108849 [details] [review]
Fixes a problem in this patch

I'm not sure, but I think you need this in that patch.
Comment 6 Carlos Garnacho 2008-04-23 11:11:37 UTC 
I've opened #529520 to handle the issues in comment #4, I think this bug can be closed :)
Comment 7 Martyn Russell 2010-05-17 13:32:53 UTC 
Moving "Indexer" component bugs to "General" since "Indexer" refers to the old 0.6 architecture