GNOME Bugzilla – Bug 526752
Deprecated symbols should be marked with macro ATK_DISABLE_DEPRECATED
Last modified: 2008-06-19 08:48:31 UTC
As it's done with GTK and GDK deprecated symbols, ATK should have its own DEPRECATED macro, in order to have options to generate docs with or without deprecated info, and in order to let bindings now about deprecated stuff in order for them to mark it as well. Other information: I am cooking a patch.
Mike Gorse told me he was going to fix this. I don't have enough edit rights to assign it to him. Could you do it Li?
Created attachment 109060 [details] [review] Patch - adds ATK_DISABLE_DEPRECATED This is partly Andres's work and partly mine. svn mv atk/atk.def atk/atk.symbols should be run before applying. This change, and the corresponding change to Makefile.am, allow preprocessing macros to be used when generating atk.def (this is parallel to what is done in gtk). It might be useful to define ATK_DISABLE_DEPRECATED in Makefile.am; this patch doesn't do this, but I don't think that it matters much either way. This change allows the C# binding generator to know which functions are deprecated and add an "obsolete" tag as appropriate. There should be no functional change.
li.yuan: ping, can you review the patch please? Thanks.
I don't see ATK_DISABLE_DEPRECATED defined. Does docs generator will define this macro based on library names?
Created attachment 112928 [details] [review] revised patch I looked again at gtk, and it does define GTK_DISABLE_DEPRECATED, so maybe that is standard procedure after all. I've made a new patch against the latest svn and added -DATK_DISABLE_DEPRECATED into Makefile.am.
Thanks for the patch. If you can make a patch that people don't need to do "svn mv" before applying, it would be great. :)
(In reply to comment #6) > Thanks for the patch. If you can make a patch that people don't need to do "svn > mv" before applying, it would be great. :) Are you sure about that? Converting the 'mv' operation into just addition and removals, the history of the file will not be saved (via svn log) and it will count as a newly created file. Thanks for reviewing anyways!
I mean paste a patch on this bug, just for record, let people know what has changed. When we commit, we use "mv". And it's OK to commit.
Then we could just commit and after that, paste here the URL to the message from svn-patches-list. BTW, I don't have an SVN account, and I believe Mike hasn't got one either.
http://mail.gnome.org/archives/svn-commits-list/2008-June/msg04492.html Thanks Li! I'll mark as VERIFIED when the change gets propagated to the binding.