After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526673 - matroska -> GST_EBML_SIZE_UNKNOWN
matroska -> GST_EBML_SIZE_UNKNOWN
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-07 08:35 UTC by Monika
Modified: 2008-04-07 09:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Monika 2008-04-07 08:35:19 UTC
I think that there is a bug in matroska plugin, in ebml-ids.h file.

Code is:
#define GST_EBML_SIZE_UNKNOWN          G_GINT64_CONSTANT(0x00ffffffffffffff)

should be:
#define GST_EBML_SIZE_UNKNOWN          G_GINT64_CONSTANT(0x01ffffffffffffff)

Maybe this first byte is somewhere set to 0x01 (it must be, because this byte determines size of this vint value), but I can't find this.
Comment 1 Tim-Philipp Müller 2008-04-07 09:03:44 UTC
I guess this would be the mask=0x01 in gst_ebml_write_element_size():

  if (size != GST_EBML_SIZE_UNKNOWN) {
    ...
  } else {
    mask = 0x01;
    bytes = 8;
  }

  GST_BUFFER_SIZE (buf) += bytes;
  while (bytes-- > 0) {
    data[bytes] = size & 0xff;
    size >>= 8;
    if (!bytes)
      *data |= mask;
  }

Please re-open if you still think this is incorrect.