After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526557 - [matroskademux] seeking regression in CVS
[matroskademux] seeking regression in CVS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-06 18:31 UTC by Tim-Philipp Müller
Modified: 2008-04-17 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix open-ended seeking (1.56 KB, patch)
2008-04-13 12:25 UTC, Mark Nauwelaerts 		committed Details | Review

Description Tim-Philipp Müller 2008-04-06 18:31:34 UTC 
Seeking in matroska files appears to be slighly broken in CVS.

It does work in seek (with option 14/playbin), but not in totem or with -good/tests/icles/gdkpixbufsink-test.c

Keyframe seeking doesn't seem to work properly at all, while ACCURATE seeking at least does something but produces

(lt-gdkpixbufsink-test:15738): GStreamer-CRITICAL **: gst_event_new_new_segment_full: assertion `start <= stop' failed

** (lt-gdkpixbufsink-test:15738): CRITICAL **: gst_matroska_demux_send_event: assertion `event != NULL' failed

criticals.
Comment 1 Jan Schmidt 2008-04-12 23:50:31 UTC 
We need a fix for this one pretty badly. Anyone got any ideas?
Comment 2 Mark Nauwelaerts 2008-04-13 12:25:13 UTC 
Created attachment 109167 [details] [review]
Fix open-ended seeking

If I read CVS right, this should only affect end TYPE_NONE seeks.
It is "caused" by replacing matroskademux' custom segment variables with standard core GstSegment ones, and CLAMP acts slightly differently for g(u)int64 variables when it comes to TIME_INVALID (-1), so ...

* Check (some more) for TIME_INVALID prior to calculations and comparisons.
Comment 3 Jan Schmidt 2008-04-13 22:22:53 UTC 
Looks reasonable. I'd like to get review from Wim before committing it though - let's aim to put it in the 2nd pre-release.
Comment 4 Wim Taymans 2008-04-13 22:41:41 UTC 
yeah. Ideally it should also use gst_segment_set_seek() to get all the nasty corner cases right. I guess that patch is ok for now.
Comment 5 Jan Schmidt 2008-04-14 13:38:43 UTC 
Thanks! Patch committed:

2008-04-14  Jan Schmidt  <Jan.Schmidt@sun.com>

        * gst/matroska/matroska-demux.c:
        (gst_matroska_demux_handle_seek_event):
        Fix open-ended seeks in matroskademux
        Patch by: Mark Nauwelaerts <manauw skynet be>
        Fixes: #526557