GNOME Bugzilla – Bug 526199
Gnome Panel spams console when GDM isn't running.
Last modified: 2008-06-12 23:52:33 UTC
- Kill the GDM connection failure warning. - Remove the "Switch User" button from the logout dialog when GDM isn't reachable. Other information: I currently use GNOME without using the GDM (since I am the sole user of my machine) and I know of several people doing the same. Gnome Panel is one of the few GNOME components that makes a fuss when GDM isn't unavailable leaving me with this ugly warning in my "startx" terminal: ** (gnome-panel:31807): WARNING **: Failed to establish a connection with GDM: No such file or directory GNOME Panel functions just fine without GDM so should handle its absence more gracefully.
Created attachment 108625 [details] [review] Quick and dirty fix. - Kills the "Switch User" button by testing for GDM availability, as the FIXME says in the unpatched code. - Nukes the warning, and prevents needless socket() call when we know the socket isn't going to be available because it doesn't exist.
Re-assigning to gnome-session as this is supposed to be handled there from now on.
Commited to trunk, thanks! 2008-06-13 Lucas Rocha <lucasr@gnome.org> Avoid spamming the console with error messages when GDM is not available. Check availability of GDM to know if we can add "Switch User" button to logout dialog. #526199, Andrew Nelless. Patch by Andrew Nelless. * gnome-session/gdm.[ch] (gdm_is_available, gdm_init_protocol_connection): check existence of socket file before trying to connect in order to avoid spamming console with error messages when GDM is not available. * gnome-session/logout-dialog.c (gsm_get_logout_dialog): check is GDM is available before adding "Switch User" button to logout dialog.