After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525953 - libgtop 2.22.0 broken on probably all but linux platform
libgtop 2.22.0 broken on probably all but linux platform
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: bsd
2.22.x
Other other
: Normal critical
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-03 13:21 UTC by Petr Salinger
Modified: 2008-04-04 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (858 bytes, patch)
2008-04-03 13:21 UTC, Petr Salinger 		committed Details | Review

Description Petr Salinger 2008-04-03 13:21:17 UTC 
The problem is in sysdeps/common/ subdirectory.
fsusage.c and mountlist.c are not present in tarball,
Makefile.am is written in broken way.

For details please see
http://bugs.debian.org//cgi-bin/bugreport.cgi?bug=473211

It should suffice to fix Makefile.am and rerun autoconf/automake.

Petr
Comment 1 Petr Salinger 2008-04-03 13:21:53 UTC 
Created attachment 108544 [details] [review]
proposed patch
Comment 2 Benoît Dejean 2008-04-03 15:49:03 UTC 
Hello Petr, i don't get what is broken in the Makefile.am ? Maybe it requires more recent version of auto* ?
Comment 3 Petr Salinger 2008-04-03 16:19:13 UTC 
> Hello Petr, i don't get what is broken in the Makefile.am ? Maybe it requires
> more recent version of auto* ?

Please check tarball generated by "make dist". It does not contain
files sysdeps/common/fsusage.c and sysdeps/common/mountlist.c 
event though they are in svn. The autoconf/automake does not work correctly with
"+=" operator. These filesshould be also compiled on non-linux platforms, but they are not. IMHO this is also reason for #503987.
Comment 4 Benoît Dejean 2008-04-03 16:38:05 UTC 
OK then, autocrap is definitely pure shit. += won't work but undefined variables are OK ... i guess someone never heard about the rule of the least surprise.

I'll release 2.22.1 this weekend.
Comment 5 Benoît Dejean 2008-04-04 18:28:58 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

I'm about to release 2.22.1.