After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525746 - missing #include in cups backend causes crash on x86_64 under eclipse
missing #include in cups backend causes crash on x86_64 under eclipse
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-04-02 12:18 UTC by Frederic Crozat
Modified: 2008-04-02 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing include (496 bytes, patch)
2008-04-02 12:18 UTC, Frederic Crozat 		accepted-commit_now Details | Review

Description Frederic Crozat 2008-04-02 12:18:05 UTC 
This is a follow-up of Mandriva bug https://qa.mandriva.com/show_bug.cgi?id=39711

In 2.12.9, .lpoptions parsing code is missing #include <glib/gstdio.h> which is causing :
 gtkprintbackendcups.c: In function 'cups_parse_user_default_printer':
 gtkprintbackendcups.c:1421: warning: implicit declaration of function 'g_fopen'
 gtkprintbackendcups.c:1421: warning: assignment makes pointer from integer without a cast
 gtkprintbackendcups.c: In function 'cups_parse_user_options':
 gtkprintbackendcups.c:1484: warning: assignment makes pointer from integer without a cast

This results in crash in gtk+2.0 when using on x86-64 system, which can be seen under eclipse, if a .lpoptions file is present.

Attached patch fixes the issue.
Comment 1 Frederic Crozat 2008-04-02 12:18:55 UTC 
Created attachment 108467 [details] [review]
add missing include
Comment 2 Frederic Crozat 2008-04-02 13:11:56 UTC 
oops, I missed it was already fixed on svn in both branches.

closing as fixed.