GNOME Bugzilla – Bug 525522
Some composer header signals aren't hooked up (Window title doesn't reflect subject, ...)
Last modified: 2008-04-03 16:33:10 UTC
Please describe the problem: subject_changed_cb and hdrs_changed_cb aren't hooked up anywhere and are thus never called. Apart from the most obvious symptom described below, this also causes the composer not to be considered dirty after changes to headers. I'll attach a patch which fixes this. Steps to reproduce: 1. File -> New -> Mail Message (Ctrl + N) 2. Modify the subject Actual results: The composer window title remains 'Compose Message'. Expected results: The composer window title should reflect the current subject. Does this happen every time? Yes. Other information:
Created attachment 108406 [details] [review] Fix This fixes the problems for me.
*** Bug 518104 has been marked as a duplicate of this bug. ***
Good catch. Patch looks good and works fine, so just add a Changelog entry to the composer directory and commit to stable and trunk. Thanks.
(In reply to comment #3) > Good catch. Patch looks good Thanks for the review. > and works fine, so just add a Changelog entry to the composer directory Do I need to do that? > and commit to stable and trunk. Will the fix also be backported to 2.22, as this is a regression from 2.12?
Note: Bug is not present in the new composer code for 2.23.
should get into Evolution 2.22.1, yepp. anybody feel free to commit.
Committed to gnome-2-22. Committed revision 35315. I did write a Changelog entry for you (for this time), just do not blame if you want there something else :)
(In reply to comment #7) > I did write a Changelog entry for you (for this time), just do not blame if you > want there something else :) :) Thanks! I'll try to remember including changelog entries in the future.