After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 525359 - [alaw] [mulaw] Use gst_pad_alloc_buffer_and_set_caps to create encoded buffer
[alaw] [mulaw] Use gst_pad_alloc_buffer_and_set_caps to create encoded buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-31 15:43 UTC by mersad
Modified: 2008-04-01 11:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gst_pad_alloc_buffer_and_set_caps to create encoded buffer. (921 bytes, patch)
2008-03-31 15:45 UTC, mersad 		committed Details | Review

Description mersad 2008-03-31 15:43:00 UTC 
Use gst_pad_alloc_buffer_and_set_caps to create encoded buffer.
Comment 1 mersad 2008-03-31 15:45:37 UTC 
Created attachment 108347 [details] [review]
Use gst_pad_alloc_buffer_and_set_caps to create encoded buffer.
Comment 2 Peter Kjellerstedt 2008-03-31 15:57:27 UTC 
I guess it is fine, but it should be done similarly for the other three cases as well (alaw encode, mulaw decode and alaw decode).
Comment 3 Wim Taymans 2008-04-01 11:00:59 UTC 
        Based on patch by: mersad <mersad at axis dot com>

        * gst/law/alaw-decode.c: (gst_alaw_dec_sink_setcaps),
        (gst_alaw_dec_chain), (gst_alaw_dec_change_state):
        * gst/law/alaw-decode.h:
        * gst/law/alaw-encode.c: (gst_alaw_enc_chain):
        * gst/law/mulaw-decode.c: (mulawdec_sink_setcaps),
        (gst_mulawdec_chain), (gst_mulawdec_change_state):
        * gst/law/mulaw-decode.h:
        * gst/law/mulaw-encode.c: (gst_mulawenc_chain):
        Make negotiation a bit modern.
        Use pad_alloc. Fixes #525359.