After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524870 - glibmm/helperlist.h:113: warning: suggest a space before ‘;’...
glibmm/helperlist.h:113: warning: suggest a space before ‘;’...
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: general
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-03-28 22:20 UTC by Tim Retout
Modified: 2008-03-29 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a newline before the semicolon. (403 bytes, patch)
2008-03-28 22:22 UTC, Tim Retout 		none Details | Review

Description Tim Retout 2008-03-28 22:20:30 UTC 
With g++ 4.3 and -Wextra, I get this warning when building against glibmm:

/usr/include/glibmm-2.4/glibmm/helperlist.h:113: warning: suggest a space before ‘;’ or explicit braces around empty body in ‘for’ statement
Comment 1 Tim Retout 2008-03-28 22:22:37 UTC 
Created attachment 108194 [details] [review]
Add a newline before the semicolon.

2008-03-28  Tim Retout  <tim@retout.co.uk>

        * glib/glibmm/helperlist.h (operator[]): Add a newline before
        the semicolon at the end of the 'for' loop.  Fixes g++ 4.3 warning.
Comment 2 Jonathon Jongsma 2008-03-29 18:54:27 UTC 
Thanks, committed.  In the future, it would be great if you could patch the changelog as well.  Thanks!