After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524827 - Should use glib to calculate md5 hash (last.fm)
Should use glib to calculate md5 hash (last.fm)
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 524826 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-28 16:48 UTC by Bastien Nocera
Modified: 2008-09-06 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use glib to calculate md5 hashes for last.fm plugin (2.88 KB, patch)
2008-08-03 22:26 UTC, Johannes H. Jensen 		committed Details | Review

Description Bastien Nocera 2008-03-28 16:48:00 UTC 
g_checksum_* will do the job.

lib/md5.h could probably be removed as well.
Comment 1 Christophe Fergeau 2008-03-29 23:27:31 UTC 
g_checksum_* was added in glib 2.16 which was released this month, so for now,
g_checksum_* use would have to be optional (or rb would need to ship a copy of
gchecksum.[ch] for people with older glibs)
Comment 2 Bastien Nocera 2008-07-29 16:52:33 UTC 
The minimum GLib req was upped, so this should be an easy bug to fix now.
Comment 3 Johannes H. Jensen 2008-08-03 22:26:31 UTC 
Created attachment 115794 [details] [review]
Use glib to calculate md5 hashes for last.fm plugin

Tested and works. lib/md5.{c,h} can now be removed.
Comment 4 Bruce Cowan 2008-08-04 19:17:26 UTC 
I worked on this just now, but I seem to be a bit late. Anyway, I thought I'd mention that the DAAP plugin has its own MD5 code as well. To be precise, it's in rb-daap-hash.c.
Comment 5 Jonathan Matthew 2008-08-05 11:46:54 UTC 
The code in the DAAP plugin is not really MD5.  One of the constants is slightly different (lines 275-282).

I've committed the patch.  Thanks, Johannes.
Comment 6 Bastien Nocera 2008-09-06 21:20:39 UTC 
*** Bug 524826 has been marked as a duplicate of this bug. ***