After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524244 - The coding style is not PEP-8' spaces compliant
The coding style is not PEP-8' spaces compliant
Status: RESOLVED FIXED
Product: gyrus
Classification: Other
Component: general
gyrus-python
Other Linux
: Normal normal
: ---
Assigned To: Gyrus Maintainers
Gyrus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-25 02:49 UTC by Germán Poo-Caamaño
Modified: 2008-04-02 19:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makes the python code PEP-8's compliant (89.39 KB, patch)
2008-03-25 02:50 UTC, Germán Poo-Caamaño
committed Details | Review
fix the patch (6.27 KB, patch)
2008-04-02 04:59 UTC, Francisco Rojas
committed Details | Review

Description Germán Poo-Caamaño 2008-03-25 02:49:29 UTC
The coding style for spaces doesn't follow PEP-8.

It uses tabs instead 4 spaces.
Comment 1 Germán Poo-Caamaño 2008-03-25 02:50:18 UTC
Created attachment 107969 [details] [review]
Makes the python code PEP-8's compliant
Comment 2 Claudio Saavedra 2008-03-25 02:56:16 UTC
Thanks. Please commit.
Comment 3 Germán Poo-Caamaño 2008-03-25 03:19:52 UTC
Committed in gyrus-python branch.
Comment 4 Francisco Rojas 2008-04-02 04:59:34 UTC
Created attachment 108453 [details] [review]
fix the patch

the old patch made some bug in the code
Comment 5 Claudio Saavedra 2008-04-02 19:23:31 UTC
Francisco,

I committed your patch, thank you. Next time, please reopen the bug if there are still issues and a new fix is neccessary.

2008-04-02  Claudio Saavedra  <csaavedra@gnome.org>

	* src/gyrus.py: Fix some indentation glitches with previous patch.
	Fixes bug #524244 (Francisco Rojas).