After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523950 - GtkTreeModelFilter's visible function may get an empty row
GtkTreeModelFilter's visible function may get an empty row
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-03-23 07:23 UTC by Björn Lindqvist
Modified: 2008-08-02 04:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Explain and show how iterators pointing to empty rows should be handled in the visible function (1.01 KB, patch)
2008-03-23 07:24 UTC, Björn Lindqvist 		committed Details | Review

Description Björn Lindqvist 2008-03-23 07:23:19 UTC 
This one tripped me over so I think it should have an entry in the manual. :) The callback function assigned with gtk_tree_model_filter_set_visible_func() is called on the row-inserted signal when the row is empty. So the docstring should mention that it is important to deal with rows with no data, otherwise bad things may happen.
Comment 1 Björn Lindqvist 2008-03-23 07:24:38 UTC 
Created attachment 107853 [details] [review]
Explain and show how iterators pointing to empty rows should be handled in the visible function
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2008-04-16 06:33:24 UTC 
Quick fix. Minor nitpick: whoever commits, please replace // for /* */ :)

http://live.gnome.org/GtkLove/PatchTriaging spam.
Comment 3 Matthias Clasen 2008-07-29 14:26:34 UTC 
Yeah, with the fix pointed out by Diego, it is fine to commit. 
Hint: use /* */ for doing this inside a doc comment.
Comment 4 Matthias Clasen 2008-08-02 04:42:56 UTC 
2008-08-02  Matthias Clasen  <mclasen@redhat.com>

        Bug 523950 – GtkTreeModelFilter's visible function may get an empty
        row

        * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_set_visible_func):
        Explain and show how iterators pointing to empty rows should be
        handled in the visible function. Patch by Björn Lindqvist