After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523883 - Thumbnails for 200% zoom are regenerated each time a folder is opened.
Thumbnails for 200% zoom are regenerated each time a folder is opened.
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 531987 539191 553717 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-22 17:14 UTC by Sebastien Bacher
Modified: 2010-04-01 21:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Force thumbnail size for compact view, only load original for thumbnail if scaling up more than 25%. (2.21 KB, patch)
2009-03-13 09:10 UTC, Alexander Larsson
accepted-commit_after_freeze Details | Review

Description Sebastien Bacher 2008-03-22 17:14:44 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/204434

"Binary package hint: nautilus

When I open a folder with images (around 20 wallpaper sizes), and change the zoom level to 200%. It resizes the thumbnail image, so obviously it becomes blurry. Note this process is completed quickly.

Then it seems to create a new thumbnail from the original image with the larger thumbnail dimensions, providing sharper and aesthetically pleasing thumbnails. This process is slow but understandable.

If I close Nautilus and open the same folder (it remembers the zoom level), it's using the smaller thumbnails, than the larger sharper ones it created earlier. Then it goes around re-creating the larger thumbnails. Slows the systems down in the process.

This it deters you from setting the zoom level up in a folder, it isn't caching/saving thumbnails at a higher zoom.

This also occurs if you navigate back and forth to the folder.

This only affects the Hardy Alphas.

I tried this on Gutsy, it doesn't have a problem as it never tries to get a better thumbnail when you increase the zoom level.

When you are testing make sure the images are of wallpaper sizes then you can really see Nautilus upgrading the original thumbnail."


It also makes nautilus really slow when browsing those folders again
Comment 1 Michael Chudobiak 2008-04-17 12:38:55 UTC
Just a guess: gfile only provides G_FILE_ATTRIBUTE_THUMBNAIL_PATH for normal size thumbnails. There is no "G_FILE_ATTRIBUTE_LARGE_THUMBNAIL_PATH".

http://www.mail-archive.com/nautilus-list@gnome.org/msg04719.html

- Mike
Comment 2 Pedro Villavicencio 2008-05-07 18:10:19 UTC
*** Bug 531987 has been marked as a duplicate of this bug. ***
Comment 3 Michael Meeks 2008-05-22 09:04:22 UTC
may be related to Bug #532725# - and share a fix (?). 
Comment 4 Cosimo Cecchi 2009-03-08 00:44:46 UTC
*** Bug 553717 has been marked as a duplicate of this bug. ***
Comment 5 Cosimo Cecchi 2009-03-08 00:52:04 UTC
*** Bug 539191 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Larsson 2009-03-11 13:51:32 UTC
Its not actually making thumbnails. For large icons we just read the actual images to use as thumbnails. Since these are not thumbnailed we of course get to re-read them on next visit. I think this is nicer, since without it you'd just look at blurred upscaled thumbnails if you choose a large zoom level.

If you don't want this, just don't choose such a large zoom level.
Comment 7 Christoph Reiter (lazka) 2009-03-11 18:21:10 UTC
My bug, which was marked as a duplicate of this pointed out that
in compact view 400% the thumbnails get regenerated every time..

but in compact view the thumb size is 100x100..

thumbsizes are 128x128, 256x256..

so this is clearly a bug.
Comment 8 Alexander Larsson 2009-03-13 08:33:27 UTC
christoph: Yeah, that seems like a bug. Maybe we're requesting too large a thumbnail in the compact view (and then scaling it down).
Comment 9 Alexander Larsson 2009-03-13 09:02:16 UTC
Testing this a bit, I think we're a bit overzealous at using the higher quality thumbnail. i.e. at 150% we're using thumbnails at 144 pixels. Its probably ok to scale these up, as its pretty close to 128.

Maybe we should limit it at 128 + 25% == 160 pixels.
Comment 10 Alexander Larsson 2009-03-13 09:10:57 UTC
Created attachment 130573 [details] [review]
Force thumbnail size for compact view, only load original for thumbnail if scaling up more than 25%.
Comment 11 Alexander Larsson 2009-03-16 14:19:51 UTC
2009-03-16  Alexander Larsson  <alexl@redhat.com>

	Bug 523883 – Thumbnails for 200% zoom are regenerated each time a folder is opened.

        * libnautilus-private/nautilus-file.c:
        (nautilus_file_get_icon):
	allow scaling up thumbnails, use the scaled up thumnail
	for up to 25% size increase.

        * src/file-manager/fm-icon-container.c:
        (fm_icon_container_get_icon_images):
	Force thumbnail size for compact view to avoid loading at wrong size
	and then rescaling