After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523798 - [API] Some GstMiniObject enhancements
[API] Some GstMiniObject enhancements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-22 06:44 UTC by Sebastian Dröge (slomo)
Modified: 2008-04-03 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mini-object.diff (4.51 KB, patch)
2008-03-22 06:44 UTC, Sebastian Dröge (slomo)
committed Details | Review
mini-object-docs.diff (950 bytes, patch)
2008-03-22 06:44 UTC, Sebastian Dröge (slomo)
committed Details | Review
mini-object-gst-inspect.diff (882 bytes, patch)
2008-03-22 06:45 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2008-03-22 06:44:13 UTC
Hi,
the attached patch enhances GstMiniObject a bit.

It adds 

GST_IS_PARAM_SPEC_MINI_OBJECT
GST_PARAM_SPEC_MINI_OBJECT
GST_TYPE_PARAM_MINI_OBJECT
GstParamSpecMiniObject

and

gst_value_dup_mini_object()

to the public API.

This makes the API a bit more consistent with other param specs (and makes it possible to extend and check if a param spec is the one that was expected) and gst_value_dup_mini_object() is useful for set_property methods.
Comment 1 Sebastian Dröge (slomo) 2008-03-22 06:44:34 UTC
Created attachment 107781 [details] [review]
mini-object.diff
Comment 2 Sebastian Dröge (slomo) 2008-03-22 06:44:52 UTC
Created attachment 107782 [details] [review]
mini-object-docs.diff
Comment 3 Sebastian Dröge (slomo) 2008-03-22 06:45:36 UTC
Created attachment 107783 [details] [review]
mini-object-gst-inspect.diff

Print something more useful for GstMiniObject properties than "Unknown type"
Comment 4 Michael Smith 2008-03-22 14:38:16 UTC
Looks sensible (I haven't tested it here, though).

Comment 5 Sebastian Dröge (slomo) 2008-03-22 14:51:31 UTC
2008-03-22  Sebastian Dröge  <slomo@circular-chaos.org>

	* gst/gstminiobject.c: (gst_value_dup_mini_object),
	(gst_param_spec_mini_object):
	* gst/gstminiobject.h:
	* win32/common/libgstreamer.def:
	* docs/gst/gstreamer-sections.txt:
	API: Add GST_IS_PARAM_SPEC_MINI_OBJECT, GST_PARAM_SPEC_MINI_OBJECT
	GST_TYPE_PARAM_MINI_OBJECT and gst_value_dup_mini_object. Also move
	GstParamSpecMiniObject into a public header for this.

	This make GstMiniObject a bit more consistent with GObject and makes
	it possible to extend the param specs.

	gst_value_dup_mini_object is mainly useful for set_property methods.

	Fixes bug #523798.

	* tools/gst-inspect.c: (print_element_properties_info):
	Print something useful for GstMiniObject properties and not just
	"unknown type".