GNOME Bugzilla – Bug 523541
Usage e_cal_component_get_recurid_as_string () leads to leaks
Last modified: 2008-05-14 07:31:54 UTC
The patch of bug #523533 fixes a behavior the to correctly return newly allocated memory in one case. This clearly shows that we are not handling the return value of e_cal_component_get_recurid_as_string () correctly otherwise that would have lead to a lot of crashes. We should check all invocations of e_cal_component_get_recurid_as_string () and see if we handle the memory correctly.
Created attachment 107690 [details] [review] proposed evo patch for evolution; Only one, not bad.
Created attachment 107691 [details] [review] proposed eds patch for evolution-data-server; here it's more. One thing, I removed call in backends/google/e-cal-backend-google.c: (send_object):, it wasn't used there, someone whom knows the code should look and think whether it was intended or not to not use that value.
Chen/Gicmo: Can you review/Approve this?
The first patch (the one for evo) is uneccessary since we are passing the rid variable to the ItipFormatterData struct. The other one looks good. Go ahead and commit that one.
evo part committed to trunk (slightly modified). Committed revision 35275. eds part committed to trunk. Committed revision 8592. We decided on IRC to change the evo patch a bit, even I agree with gicmo, it's kinda for nothing there, just to be sure (I marked patch as obsolete, because not committed exactly that one).
Please commit the patch to stable branch too.
Reopening until this is committed to stable. Chen, you might want to just commit this yourself. Milan is on vacation for the next couple weeks.
sure, will get it done.
Committed to stable.