GNOME Bugzilla – Bug 523264
Update GTK+ reference documentation screenshots
Last modified: 2008-11-29 21:28:06 UTC
I updated the screenshots of the GTK doc reference; in order to provide the same style to all widget. I took latest clearlooks, as I look nice. some widget doesn't look nice because there are incomplete (window.png and messagedialog.png); and other are too small (filechooser.png). If you correct that, I can take these screenshots too. I also updated the file widgets.c for create_icon_view in order to use stock icons instead of old looking file icons gnome-foot.png and gnome-gmush.png; I don't know if they are used elsewhere and thus can be removed.
Created attachment 107573 [details] screenshot files
Created attachment 107574 [details] [review] patch to update the icon view widget perhaps gnome-gmush.png and gnome-foot.png can be removed if they are no more used.
any reviewer ?
Applies cleanly, quick fix. http://live.gnome.org/GtkLove/PatchTriaging spam.
I'll attach the patch in another bug to separate purpose of bugs.
Created attachment 112813 [details] Updated Recent list has example files now; please note the example for gtkfilechooser is really small; can someone points me how to fix it, or fix it directly? From gtk+/docs/tools/README.shooter: "Currently, all shots are constrained to the same width. Care should be taken when adding new widgets to keep this constraint." thanks
The comment is not literally true. If you look at the code in widgets.c, there is 3 predefined sizes, and a bunch of widgets that we manually size. Something is clearly broken with filechooser sizing right now, since the filechooser ignores the default size of 505, 305 that we set.
Created attachment 123630 [details] Updated version with a bigger filechooser window I can commit the images if you want. cheers
The recentchooser would look nicer if it has some variation in the icons, I think. Other than that, I'm ok with using these images. They need to be committed with matching changes to docs/tools/shooter that were used to generate them.
Okay, I'll change the filechooser picture. Should it be commited on trunk only or gtk-2-14 too?
recentchooser, not filechooser. Head-only please. And don't forget the shooter changes.
Yeah sorry, I updated recentchooser picture. The changes previously were posted in bug #538547 and already commited. Cheers,
I commited the pictures. thanks a lot for review. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.