After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523147 - "space" keyname is not marked for translation
"space" keyname is not marked for translation
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: i18n
unspecified
Other All
: Normal normal
: 2.22.1
Assigned To: Willie Walker
Depends on:
Blocks:
 
 
Reported: 2008-03-18 12:10 UTC by Willie Walker
Modified: 2008-03-19 05:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add _("space") to keynames.py (473 bytes, patch)
2008-03-18 12:16 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2008-03-18 12:10:51 UTC 
On the orca-list, Attila mentioned that he would still hear the English word "space" with key echo in a Hungarian locale even after he had done a 100% translation of the Hungarian po file for Orca.

With some debugging, it turns out that key echo will send on the key event string to speech if it cannot find a pronunciation in keynames.py.  There is no translation for "space" in keynames.py, so it is being passed on to speech as is.
Comment 1 Willie Walker 2008-03-18 12:16:12 UTC 
Created attachment 107526 [details] [review]
Patch to add _("space") to keynames.py

This patch adds the following lines to keynames.py:

+# Translators: this is the spoken word for the space character
+#
+__keynames["space"] = _("space")
+

Since _("space") is already used in chnames.py and default.py, this should not count as a string freeze break for GNOME 2.20.x.  The comment for translators also comes from chnames.py and default.py so as not to introduce a new translation comment.

Attila, can you please test?
Comment 2 Hammer Attila 2008-03-18 12:53:18 UTC 
Of course Will, thank you the patch.
Comment 3 Hammer Attila 2008-03-18 13:56:03 UTC 
I am tested your patch, working fine with orca 2.22-1 pre version and orca-2.23-pre version.
Comment 4 Willie Walker 2008-03-19 00:21:44 UTC 
Thanks for testing!  Committed to both trunk and gnome-2-22 branch.
Comment 5 Hammer Attila 2008-03-19 05:54:25 UTC 
Will, I would like thank you you fix this bug. Attila