After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523136 - nautilus crashed with SIGSEGV in g_str_hash()
nautilus crashed with SIGSEGV in g_str_hash()
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: Crashers
2.22.x
Other Linux
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-18 11:21 UTC by Sebastien Bacher
Modified: 2011-04-06 20:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Don't call g_hash_table_lookup with NULL (615 bytes, patch)
2008-09-04 16:06 UTC, palfrey 		needs-work Details | Review

Description Sebastien Bacher 2008-03-18 11:21:21 UTC 
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/203393

"I was trying to eject a USB stick; nautilus hung and then crashed.

Package: nautilus 1:2.22.0-0ubuntu3

.

+ Trace 192760

Thread 1 (process 10618)

  • #0 g_str_hash
    from /usr/lib/libglib-2.0.so.0
  • #1 g_hash_table_lookup
    from /usr/lib/libglib-2.0.so.0
  • #2 get_link_files
    at nautilus-file.c line 1513
  • #3 nautilus_file_emit_changed
    at nautilus-file.c line 6156
  • #4 nautilus_directory_emit_change_signals
    at nautilus-directory.c line 792
  • #5 call_files_changed_common
    at nautilus-directory.c line 884
  • #6 call_files_changed_unref_free_list
    at nautilus-directory.c line 903
  • #7 g_hash_table_foreach
    from /usr/lib/libglib-2.0.so.0
  • #8 nautilus_directory_notify_files_removed
    at nautilus-directory.c line 1172
  • #9 nautilus_file_changes_consume_changes
    at nautilus-file-changes-queue.c line 442
  • #10 call_consume_changes_idle_cb
    at nautilus-monitor.c line 68 






Comment 1


palfrey





          2008-09-04 16:06:25 UTC
        



Created attachment 118020 [details] [review]
Don't call g_hash_table_lookup with NULL

This is caused because nautilus calls g_hash_table_lookup without checking if it's using a NULL. The attached patch (against SVN 2008-09-04) adds the check.






Comment 2


Alexander Larsson





          2009-03-11 12:25:31 UTC
        



I don't think that is the right fix. 
nautilus_file_get_uri() shouldn't ever return NULL. The only reason it can happen is if this fails:

	g_return_val_if_fail (NAUTILUS_IS_FILE (file), NULL);

Which points to another problem. We're passing in an invalid (probably destroyed) file object.








Comment 3


Alexander Larsson





          2009-03-11 12:50:02 UTC
        



Although nautilus_file_emit_changed() asserts that NAUTILUS_IS_FILE (file), so this looks weird. Perhaps a callback for the "changed" signal destroys the file. Of course, nautilus_directory_notify_files_removed() refs the files, so that would be unlikely too.







Comment 4


Cosimo Cecchi





          2011-04-06 20:18:45 UTC
        



Marking pre 2.30 bugs with no dups as OBSOLETE.