After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522882 - Add a configure option to enable/disable OPTION_PARSING in gst_init
Add a configure option to enable/disable OPTION_PARSING in gst_init
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.18
Other Linux
: Low enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-17 05:19 UTC by Jason Zhao
Modified: 2008-04-03 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configue.ac patch (770 bytes, patch)
2008-03-17 05:20 UTC, Jason Zhao 		none Details | Review

Description Jason Zhao 2008-03-17 05:19:22 UTC 
Add a configure option to enable/disable OPTION_PARSING in gst_init.

default is enable OPTION_PARSING

Changed files:
configure.ac

Motorola would like to contribute Gstreamer patch to the  Gstreamer open source
community project. Please find attached the patch applicable for Gstreamer. For
any questions, please feel free to contact (Zhao Liang "e3423c@motorola.com",
Shi Ling "w20230@motorola.com").
Comment 1 Jason Zhao 2008-03-17 05:20:11 UTC 
Created attachment 107426 [details] [review]
configue.ac patch
Comment 2 Thomas Vander Stichele 2008-03-25 13:02:14 UTC 
Hi,

 - what is the goal of disabling option parsing ? Why is it useful ?
 - it looks like your patch is missing something since it only patches configure.ac, and nothing is reacting on the change ?
Comment 3 Jason Zhao 2008-03-26 02:00:32 UTC 
In gst.c gst_init_check, there is a Marco GST_DISABLE_OPTION_PARSING which is used to disable option parsing, but no option in configure, my patch is to do this.

Generally, to improve performance, OPTION_PARSING is not used sometimes.
Comment 4 Julien MOUTTE 2008-03-28 13:01:07 UTC 
I have checked the ChangeLog and indeed it seems David Schleef forgot to add the define in a configure switch.

Adding him to the ticket.

Are we okay for commit ?
Comment 5 David Schleef 2008-03-28 20:07:38 UTC 
Oops, saw this but forgot to comment on it.  Yeah, it's ok.
Comment 6 Julien MOUTTE 2008-04-01 10:27:40 UTC 
Committed in CVS HEAD.