After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522783 - Signature separator for HTML E-mails
Signature separator for HTML E-mails
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[composer] evolution[signatu...
Depends on:
Blocks:
 
 
Reported: 2008-03-16 16:03 UTC by Philip Van Hoof
Modified: 2009-10-16 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed evo patch (1.39 KB, patch)
2009-08-05 21:31 UTC, Milan Crha
committed Details | Review

Description Philip Van Hoof 2008-03-16 16:03:44 UTC
Although perhaps not a written standard, although I'm confident somebody
once wrote this down, are E-mail clients who do it right adding "-- \n"
in front of the signature. This way can receiving E-mail clients and
mailing lists do something with the signature (for example, moving the
personal signature lower, adding advertising or legal warnings).

Evolution is getting this right for text/plain signatures, but not for
text/html ones. For the text/plain signature you don't need to add any
such characters, Evolution will do this for you. For the text/html
signature, you do (inconsistency).

For E-mails where you send both the text/plain and the text/html MIME
parts, you therefore can't really define it for your E-mails. Unless you
change the text/html signature to contain this "-- \n" sequence and not
add it to the text/plain. Or if you don't want it ... well you then
can't really define the desired behaviour for the text/plain one
(inconsistency++ + confusion).

In any case, it's not consistent. Therefore confusing, and in my opinion
therefore incorrect behaviour.

ps. Since in HTML \n is not visible, I'd use "-- \n<br/>"
Comment 1 Milan Crha 2009-08-05 21:14:31 UTC
Note that it's not <br/>, but <br>, as "br" is not a pair element.
Comment 2 Milan Crha 2009-08-05 21:31:34 UTC
Created attachment 139981 [details] [review]
proposed evo patch

for evolution;

I'm not sure whether I got it right, thus rather adding here for some testing by someone else too. Note that one is able to disable signature delimiters completely by a gconf key /apps/evolution/mail/composer/no_signature_delim now.
Comment 3 Milan Crha 2009-10-16 09:23:48 UTC
Created commit 3827cbe in evo master (2.29.1+)

--------

Reapplied patch from bug #551470, as this got dropped on merging.

Be sure	you call also
gconftool-2 --install-schema-file=$PREFIX/etc/gconf/schemas/evolution-mail.schemas
as new key had been added.