After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522458 - Use gio from glib
Use gio from glib
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on: 522456
Blocks: 522462
 
 
Reported: 2008-03-14 16:56 UTC by Morten Welinder
Modified: 2008-08-27 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Living-life-in-the-fast-lane (6.92 KB, patch)
2008-03-17 01:49 UTC, Morten Welinder
none Details | Review
very preliminary patch. (2.95 KB, patch)
2008-08-03 16:38 UTC, Jean Bréfort
none Details | Review
full patch (20.14 KB, patch)
2008-08-06 09:41 UTC, Jean Bréfort
committed Details | Review

Description Morten Welinder 2008-03-14 16:56:58 UTC
We should drop gnome-vfs as a dependency asap.  (Conditional on gio
support in libgsf.)
Comment 1 Dominic Lachowicz 2008-03-14 18:07:21 UTC
GSF has GIO support: http://svn.gnome.org/viewvc/libgsf/trunk/gsf-gvfs/

When I wrote and tested it, GIO hadn't been merged into glib, so this may need a *bit* of tweaking to get working again.
Comment 2 Morten Welinder 2008-03-17 01:49:01 UTC
Created attachment 107421 [details] [review]
Living-life-in-the-fast-lane

I know what you're thinking. Did he patch six places or only five?
Well, to tell you the truth, in all this excitement, I've kinda lost
track myself. But being as this is a .44 Magnum, the most powerful
patch in the world, and would blow your head clean off, you've
got to ask yourself one question: Do I feel lucky? Well, do ya,
punk?
Comment 3 Jean Bréfort 2008-08-03 16:38:11 UTC
Created attachment 115781 [details] [review]
very preliminary patch.

g_content_type_guess can return only ".txt" or "*" on win32, so we still need our win32 specific code.
Comment 4 Dominic Lachowicz 2008-08-04 01:10:07 UTC
AbiWord has a copy of go-file.c with a lot of modifications, including some decent support for GIO. We should look into merging these changes upstream into libgoffice and libgsf.

http://www.abisource.com/viewvc/abiword/trunk/src/af/util/xp/ut_go_file.cpp?view=markup
Comment 5 Jean Bréfort 2008-08-06 09:41:44 UTC
Created attachment 115957 [details] [review]
full patch

Dom, did not see your last comment before (seems I was not cced for this bug). I'll have a look to the abi version.
Comment 6 Jean Bréfort 2008-08-06 09:45:12 UTC
When this one is fixed, we are left with to other uses of the with-gnome stuff:
- gnome_show_url and gnome_help_display which should be replaced with gtk_show_url when available.
- the gconf code for which I propose to use GOFFICE_WITH_GCONF instead.

Am I missing anything?
Comment 7 Jean Bréfort 2008-08-27 12:17:01 UTC
Commited my patch after using it for some times.