After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522326 - use of 'char*' instead of 'const char*' in gst_caps_set_simple() and gst_caps_set_simple_valist()
use of 'char*' instead of 'const char*' in gst_caps_set_simple() and gst_caps...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-13 22:15 UTC by José Alburquerque
Modified: 2008-04-03 15:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Patch to correct field parameter 'char*' to 'const char*' in gst_caps_set_simple{,_valist} (2.01 KB, patch)
2008-03-13 22:17 UTC, José Alburquerque 		committed Details | Review

Description José Alburquerque 2008-03-13 22:15:11 UTC 
I get the sense that the field parameter in gst_caps_set_simple() and gst_caps_set_simple_valist() should be 'const char*' so I'm submitting this patch.  Okay?
Comment 1 José Alburquerque 2008-03-13 22:17:45 UTC 
Created attachment 107249 [details] [review]
Patch to correct field parameter 'char*' to 'const char*' in gst_caps_set_simple{,_valist}
Comment 2 Wim Taymans 2008-03-18 11:46:51 UTC 
I think this makes sense. Waiting to commit until after the freeze.
Comment 3 Wim Taymans 2008-03-24 10:33:50 UTC 
        Patch by:  José Alburquerque <jaalburqu at svn dot gnome dot org>

        * gst/gstcaps.c: (gst_caps_set_simple),
        (gst_caps_set_simple_valist), (gst_caps_intersect):
        * gst/gstcaps.h:
        Constify the field gchar * params in set_simple and friends.
        Fixes #522326.