After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521875 - [osssrc] recording corrupts upon _get_caps
[osssrc] recording corrupts upon _get_caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.7
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-11 21:50 UTC by Mark Nauwelaerts
Modified: 2008-03-11 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch (1.63 KB, patch)
2008-03-11 21:52 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2008-03-11 21:50:03 UTC 
Unlike e.g. alsasrc/sink and osssink, which return cached earlier probed caps, osssrc performs an actual (ioctl etc) probe upon _get_caps (e.g. during some caps negotiation), which interferes with possibly ongoing recording.
Comment 1 Mark Nauwelaerts 2008-03-11 21:52:12 UTC 
Created attachment 107097 [details] [review]
Possible patch

* Cache probed caps and return these in _get_caps request.

[as is the case in the other aforementioned plugins]
Comment 2 Tim-Philipp Müller 2008-03-11 23:13:37 UTC 
Committed, thanks:

 2008-03-11  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts <manauw skynet be>

        * sys/oss/gstosssrc.c: (gst_oss_src_init), (gst_oss_src_getcaps),
          (gst_oss_src_close):
        * sys/oss/gstosssrc.h:
          Cache probed caps, so _get_caps() during recording doesn't cause
          ioctl calls which may disrupt the recording (fixes #521875).