After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521803 - Refactor request and file processing
Refactor request and file processing
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Martyn Russell
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2008-03-11 16:35 UTC by Martyn Russell
Modified: 2008-03-26 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the bug (121.62 KB, patch)
2008-03-11 16:48 UTC, Martyn Russell 		committed Details | Review

Description Martyn Russell 2008-03-11 16:35:13 UTC 
I have a patch which moves the functions required to handle DBus messages and indexing files into their own modules instead of all being in trackerd.c. 

This makes the code a lot more maintainable and easier to follow due to the functions now have been made smaller and easier to comprehend as a result.

Patch to follow.
Comment 1 Martyn Russell 2008-03-11 16:48:27 UTC 
Created attachment 107072 [details] [review]
Patch to fix the bug

All I would add is, I did a quick review of my own bug and the patch does look like it removes code it shouldn't but that's only because large chunks of the file have been moved to other files. This patch is best reviewed after being patched I think (at least for trackerd.c), the two new files tracker-process-files.c and tracker-process-requests.c have all the new code that has been moved over. These contain the mutex/threading voodoo which needs checking.
Comment 2 Martyn Russell 2008-03-26 11:36:19 UTC 
Committed.