After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521191 - gnome-games-2.20.3 failes to compile
gnome-games-2.20.3 failes to compile
Status: RESOLVED DUPLICATE of bug 520599
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.20.x
Other All
: Normal critical
: ---
Assigned To: GGZ Gaming Zone bugtracker gateway
GGZ Gaming Zone bugtracker gateway
Depends on:
Blocks:
 
 
Reported: 2008-03-08 13:51 UTC by rehsack
Modified: 2012-01-31 23:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description rehsack 2008-03-08 13:51:26 UTC
Please describe the problem:
Every time I tried to recompile gnome-games, it failed at the same point (see below). I took a look into gnect/src/ggz-network.c and recognize, that there is an argument more to ggz_gtk_initialize() than expected. ggz_gtk_initialize expects 7 arguments, on_network_game() submits 8.

Steps to reproduce:
1. take the 2.20.3 tag of gnome-games/gnect or any newer version (it's buggy in trunk, too)
2. compile it against ggz-gtk-client 0.0.14 or newer
3. wait for the compiler error


Actual results:
Compiler aborts with error

Expected results:
compilation runs through successfully ;)

Does this happen every time?
Jepp :/

Other information:
cc -DHAVE_CONFIG_H -I. -I../.. -I.. -I../../libgames-support -DGNOMELOCALEDIR=\""/usr/local/share/locale"\" -DDATADIR=\""/usr/local/share"\" -DGNECT_DATA_DIR=\""/usr/local/share/"\" -std=gnu89 -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2   -DORBIT2=1 -D_REENTRANT -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -DORBIT2=1 -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include/libxml2 -I/usr/local/include -I/usr/local/include/libgnome-2.0 -I/usr/local/include/orbit-2.0 -I/usr/local/include/gconf/2 -I/usr/local/include/gnome-vfs-2.0 -I/usr/local/lib/gnome-vfs-2.0/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libbonobo-2.0 -I/usr/local/include/bonobo-activation-2.0 -I/usr/local/include/libgnomeui-2.0 -I/usr/local/include/libart-2.0 -I/usr/local/include/gnome-keyring-1 -I/usr/local/include/libbonoboui-2.0 -I/usr/local/include/libgnomecanvas-2.0 -I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/freetype2 -I/usr/local/include/gail-1.0 -I/usr/local/include/atk-1.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/cairo   -I/usr/local/include/pygtk-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -I/usr/local/include/librsvg-2 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/gtk-2.0   -D_REENTRANT -I/usr/local/include/gstreamer-0.10 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libxml2 -I/usr/local/include   -I../../libgames-support -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -I../../dependencies/ggzmod -I../../dependencies/ggz-gtk -I../../dependencies/ggzcore -I../../dependencies/libggz -I../../dependencies/libggz -I../../dependencies/ggzdmod  -I/usr/local/include  -O2 -fno-strict-aliasing -pipe -march=pentium3 -D_REENTRANT -MT ggz-network.o -MD -MP -MF .deps/ggz-network.Tpo -c -o ggz-network.o ggz-network.c
ggz-network.c: In function 'on_network_game':
ggz-network.c:282: error: too many arguments to function 'ggz_gtk_initialize'
gmake[3]: *** [ggz-network.o] Error 1
gmake[3]: Leaving directory `/usr/ports/games/gnome-games/work/gnome-games-2.20.3/gnect/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/games/gnome-games/work/gnome-games-2.20.3/gnect'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/games/gnome-games/work/gnome-games-2.20.3'
gmake: *** [all] Error 2
*** Error code 2
Comment 1 rehsack 2008-03-08 13:56:49 UTC
Compilation error occurs on:

FreeBSD bina.muppets.liwing.de 7.0-STABLE FreeBSD 7.0-STABLE #0: Sat Mar  1 12:01:13 UTC 2008     root@bina.muppets.liwing.de:/usr/obj/usr/src/sys/BINA  i386

Maybe Joe Marcus Clarke knows more ... if this bothers you, Marcus, I'm sorry about that.
Comment 2 Andreas Røsdal 2008-03-09 18:37:23 UTC
Hello, 

which version of GGZ are you using?
Comment 3 Roger Light 2008-03-09 18:58:37 UTC
This shouldn't happen because gnect should be using the internal version of ggz-gtk which does have 8 arguments.

I'd suggest the problem is that the external ggz-gtk includes are being used in preference to the internal ones.

Rehsack - does it still fail if you uninstall ggz-gtk-client first?
Comment 4 Joe Marcus Clarke 2008-03-09 19:20:57 UTC
The problem is indeed that the system ggz headers are found before the internal ggz headers.  The order of the includes needs to be changed in the Makefile so that the internal versions are found first.  This should not affect gnome-games 2.22 as we are using the system ggz there.
Comment 5 rehsack 2008-03-10 00:44:28 UTC
Thanks Marcus.

Question to gnome-games developers: will there be an update available which fixes that or is it rated as a FreeBSD-Problem (which will force someone (me?) to create a patch for 2.20)?
Comment 6 Andreas Røsdal 2008-04-04 23:04:23 UTC
I think the changes in bug #520599 solved this compilation error.
Could any of you with this problem please try compiling gnome-games from SVN trunk?
Comment 7 Andreas Røsdal 2008-04-09 17:37:15 UTC
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.


*** This bug has been marked as a duplicate of 520599 ***
Comment 8 Robert Ancell 2012-01-31 23:29:25 UTC
This bug is being reassigned to the "general" component so we can close the ggz bugzilla component.  Apologies for the mass email!