GNOME Bugzilla – Bug 521069
some tool options not being saved or restored for some tools
Last modified: 2008-10-30 20:10:49 UTC
Please describe the problem: the following tools are not having the following options saved. Fuzzy Select tool is not remembering its antialiasing setting (won't stay off) Free Select tool is also not remembering its antialiasing setting (won't stay off) Steps to reproduce: 1. Make sure to set gimp to remember tool options: File -> Preferences -> Tool Options -> Save tool options on exit 2. Activate Fuzzy Select (or Free Select) and turn off antialiasing. 3. Close gimp and restart. Actual results: The tools antialiasing will have forgotten its settings and antialiasing will be turned back on. Expected results: The antialiasing setting would remain off. Does this happen every time? yes Other information:
Is the value stored in ~/.gimp-2.4/tool-options/gimp-fuzzy-select-tool ?
What I have found happening in the file ~/.gimp-2.4/tool-options/gimp-fuzzy-select-tool: -when antialiasing is on an (antialias yes) line is added to the config file -when antialiasing is off the config file will have no antialias line. -if the config file has no antialias line the gimp will turn on antialiasing. -if you manually add an (antialiasing no) line the gimp will start with antialiasing off, but on quit will remove the line from the config file and on restart will turn antialiasing back on.
This is a bug in how we mistreat the selecion option's antialias GParamSpec. Will fix that.
Fixed in SVN trunk, leaving open because I'm working on the backport. 2008-03-09 Michael Natterer <mitch@gimp.org> Fix mishandling of the "antialias" GParamSpec. Fixes bug #521069: * app/tools/gimpselectionoptions.c: remove gimp_selection_options_reset() which used to set the default for "antialias" depending on the tool type (which is impossible since the antialias GParamSpec only exists once, and not once for each subclass). * app/tools/gimpforegroundselectoptions.c: override the antialias property here and default to FALSE.
Fixed in 2.4, closing as FIXED. 2008-03-09 Michael Natterer <mitch@gimp.org> Merged from trunk (slightly modified): Fix mishandling of the "antialias" GParamSpec. Fixes bug #521069: * app/tools/gimpselectionoptions.c (gimp_selection_options_reset): don't set the default for "antialias" depending on the tool type (which is impossible since the antialias GParamSpec only exists once, and not once for each subclass). * app/tools/gimpforegroundselectoptions.c: override the antialias property here and default to FALSE.